New issue
Advanced search Search tips

Issue 904726 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 14
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in CPDF_DocPageData::GetPattern

Project Member Reported by ClusterFuzz, Nov 13

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5395659219533824

Fuzzer: attekett_surku_fuzzer
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  CPDF_DocPageData::GetPattern
  CPDF_Color::operator=
  CPDF_ColorState::ColorData* fxcrt::SharedCopyOnWrite<CPDF_ColorState::ColorData>
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=606189:606190

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5395659219533824

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 13

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 13

Labels: Test-Predator-Auto-Owner
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/3ec52874da605fe3a28eadaebec47d6e86da4fa5 (Remove some checks that are never true in patterns code.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/a89ef2b38df07e4e19c8f43e8f58e265c190336b

commit a89ef2b38df07e4e19c8f43e8f58e265c190336b
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Nov 14 02:26:32 2018

Revert "Remove some checks that are never true in patterns code."

This reverts commit 3ec52874da605fe3a28eadaebec47d6e86da4fa5.

Reason for revert:  https://crbug.com/904726 

Original change's description:
> Remove some checks that are never true in patterns code.
>
> Change-Id: I8f589c1fa91d140e11d6ee4edd02daa30d224ac3
> Reviewed-on: https://pdfium-review.googlesource.com/c/45190
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: Lei Zhang <thestig@chromium.org>

TBR=thestig@chromium.org,tsepez@chromium.org
BUG= chromium:904726 

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I00dd954f5b2381efddc23f7a406c36d7e788910a
Reviewed-on: https://pdfium-review.googlesource.com/c/45510
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/a89ef2b38df07e4e19c8f43e8f58e265c190336b/core/fpdfapi/page/cpdf_docpagedata.cpp
[modify] https://crrev.com/a89ef2b38df07e4e19c8f43e8f58e265c190336b/core/fpdfapi/page/cpdf_tilingpattern.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6954fbf79e21729a53e92ee04df585d47db0f96

commit c6954fbf79e21729a53e92ee04df585d47db0f96
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Nov 14 05:23:48 2018

Roll src/third_party/pdfium d20b521f5864..a89ef2b38df0 (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/d20b521f5864..a89ef2b38df0


git log d20b521f5864..a89ef2b38df0 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 thestig@chromium.org Revert "Remove some checks that are never true in patterns code."


Created with:
  gclient setdep -r src/third_party/pdfium@a89ef2b38df0

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:904726 
TBR=dsinclair@chromium.org

Change-Id: I39606d138b366282511ab755607a1a9e9c127a18
Reviewed-on: https://chromium-review.googlesource.com/c/1335093
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607913}
[modify] https://crrev.com/c6954fbf79e21729a53e92ee04df585d47db0f96/DEPS

Project Member

Comment 5 by ClusterFuzz, Nov 14

ClusterFuzz has detected this issue as fixed in range 607912:607913.

Detailed report: https://clusterfuzz.com/testcase?key=5395659219533824

Fuzzer: attekett_surku_fuzzer
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  CPDF_DocPageData::GetPattern
  CPDF_Color::operator=
  CPDF_ColorState::ColorData* fxcrt::SharedCopyOnWrite<CPDF_ColorState::ColorData>
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=606189:606190
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=607912:607913

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5395659219533824

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Nov 14

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5395659219533824 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment