New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 904711 link

Starred by 2 users
Status: Started
Owner:
drinkcat@chromium.org
Cc:
█ gkihumba@chromium.org
█ stimim@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

soraka: touchpad detected as a touchscreen by libinput

Project Member Reported by tfiga@chromium.org, Nov 13 
I'm doing some upstream Linux testing on a Soraka and libinput seems to detect the touchpad as a touchscreen, which renders it unusable, since it's stuck with absolute mode and fingers are being tracked as mouse button pressed.

According to drinkcat@, it can be fixed with a firmware update. It would be very helpful for further upstream testing on Soraka, so filing a bug to track it.

Comment 1 by drinkcat@chromium.org, Nov 13

Cc: stimim@chromium.org
Components: -OS>Hardware>Firmware OS>Firmware>EC
Status: Started (was: Assigned)
Picked 3 patches to FW branch here, that should help:
https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1333947
https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1333948
https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1333949

Travelling now, so I'll test when I'm back in the office.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 19

Labels: merge-merged-firmware-poppy-10431.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/08500a9f30f50a56942b2e136e298ad9c8448582

commit 08500a9f30f50a56942b2e136e298ad9c8448582
Author: Wei-Han Chen <stimim@google.com>
Date: Mon Nov 19 01:24:14 2018

usb_hid_touchpad.c: change report_desc to USAGE(touch pad)

BRANCH=none
BUG=b:70482333
BUG=chromium:904711
TEST=tested on device
Signed-off-by: Wei-Han Chen <stimim@chromium.org>

Change-Id: Ifc1ece2de00979e171f0a29226d927da3951515e
Reviewed-on: https://chromium-review.googlesource.com/1124267
Commit-Ready: Wei-Han Chen <stimim@chromium.org>
Tested-by: Wei-Han Chen <stimim@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
(cherry picked from commit 925798c329cd6780663144ca9d90dbfa90560b1b)
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1333947

[modify] https://crrev.com/08500a9f30f50a56942b2e136e298ad9c8448582/chip/stm32/usb_hid_touchpad.c
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/0040af5c9cdfa2f04e748c810faca80863b2c941

commit 0040af5c9cdfa2f04e748c810faca80863b2c941
Author: Wei-Han Chen <stimim@google.com>
Date: Mon Nov 19 01:24:15 2018

usb_hid_touchpad: make max pressure configurable

Maximum pressure is now defined by
CONFIG_USB_HID_TOUCHPAD_LOGICAL_MAX_Z.

`hammer` is the only board using usb_hid_touchpad, the board.h is
updated to reflect the change (for old boards "HAMMER" and "STAFF", we
keep the value 1023, so they should behave the same).

BRANCH=none
BUG=b:70482333
BUG=chromium:904711
TEST=make BOARD=whiskers
TEST=make buildall -j
TEST=manually on device
Signed-off-by: Wei-Han Chen <stimim@chromium.org>

Change-Id: I70b0a5b19dfbe3ac731ef2ead08578a7f7a1cb0b
Reviewed-on: https://chromium-review.googlesource.com/1141676
Commit-Ready: Wei-Han Chen <stimim@chromium.org>
Tested-by: Wei-Han Chen <stimim@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1333948
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>

[modify] https://crrev.com/0040af5c9cdfa2f04e748c810faca80863b2c941/chip/stm32/usb_hid_touchpad.c
[modify] https://crrev.com/0040af5c9cdfa2f04e748c810faca80863b2c941/board/hammer/board.h
[modify] https://crrev.com/0040af5c9cdfa2f04e748c810faca80863b2c941/include/config.h
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/7460aafceb269e3ac79b87c7b425a1cae59a275a

commit 7460aafceb269e3ac79b87c7b425a1cae59a275a
Author: Wei-Han Chen <stimim@google.com>
Date: Mon Nov 19 01:24:16 2018

stm32: usb_hid_touchpad: add confidence

`confidence` is expected from a PTP-compliant touchpad

BRANCH=none
BUG=b:70482333
BUG=chromium:904711
TEST=manual
Signed-off-by: Wei-Han Chen <stimim@chromium.org>

Change-Id: Ibe7166f43cae5fb36bbcc4e6dfd9ae6525a7225e
Reviewed-on: https://chromium-review.googlesource.com/1188170
Commit-Ready: Wei-Han Chen <stimim@chromium.org>
Tested-by: Wei-Han Chen <stimim@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1333949
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>

[modify] https://crrev.com/7460aafceb269e3ac79b87c7b425a1cae59a275a/driver/touchpad_st.c
[modify] https://crrev.com/7460aafceb269e3ac79b87c7b425a1cae59a275a/include/usb_hid_touchpad.h
[modify] https://crrev.com/7460aafceb269e3ac79b87c7b425a1cae59a275a/chip/stm32/usb_hid_touchpad.c
[modify] https://crrev.com/7460aafceb269e3ac79b87c7b425a1cae59a275a/board/hammer/board.h
[modify] https://crrev.com/7460aafceb269e3ac79b87c7b425a1cae59a275a/driver/touchpad_elan.c

Comment 5 by drinkcat@chromium.org, Nov 19 

Tomasz, can you please help pick and deploy this CL to Chrome OS, reboot (so the update gets applied), then try again under Linux:
https://chrome-internal-review.googlesource.com/c/chromeos/overlays/overlay-soraka-private/+/718559

Comment 6 by tfiga@chromium.org, Nov 19 

Verified that it fixes the misdetection on Linux.

Comment 7 by drinkcat@chromium.org, Nov 28

Cc: gkihumba@chromium.org
►

Sign in to add a comment