New issue
Advanced search Search tips

Issue 904709 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

tael: build fails in x11-base/xwayland, due to implicit major(), minor(), etc.

Project Member Reported by briannorris@chromium.org, Nov 13

Issue description

A lot of failure recently:

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8930293278740096448

https://cros-goldeneye.corp.google.com/chromeos/legoland/builderHistory?buildConfig=tael-paladin&buildBranch=master

It looks like it reproduces in ToT when I build locally:

../../xorg-server-1.20.1/config/udev.c:126:49: error: implicit declaration of function 'major' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        if (xf86_find_platform_device_by_devnum(major(devnum), minor(devnum)))
                                                ^
../../xorg-server-1.20.1/config/udev.c:126:49: warning: this function declaration is not a prototype [-Wstrict-prototypes]
../../xorg-server-1.20.1/config/udev.c:126:64: error: implicit declaration of function 'minor' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        if (xf86_find_platform_device_by_devnum(major(devnum), minor(devnum)))
                                                               ^


I'm guessing this was an existing package error, but it may have been hidden by some linux-headers behavior (e.g., old linux-headers didn't force you to include <sys/sysmacros.h>, but now that we're rev-bumping linux-headers again, rebuilds are uncovering the error?). This CL is in most (?) of the failing runs:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1324989
 
Labels: -Pri-3 Pri-1
Cc: za...@chromium.org
Owner: manojgupta@chromium.org
https://chromium-review.googlesource.com/1331008 is in flight to fix
Status: Fixed (was: Untriaged)
CL:1331008 is now in.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 29

Sign in to add a comment