tael: build fails in x11-base/xwayland, due to implicit major(), minor(), etc. |
|||
Issue descriptionA lot of failure recently: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8930293278740096448 https://cros-goldeneye.corp.google.com/chromeos/legoland/builderHistory?buildConfig=tael-paladin&buildBranch=master It looks like it reproduces in ToT when I build locally: ../../xorg-server-1.20.1/config/udev.c:126:49: error: implicit declaration of function 'major' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (xf86_find_platform_device_by_devnum(major(devnum), minor(devnum))) ^ ../../xorg-server-1.20.1/config/udev.c:126:49: warning: this function declaration is not a prototype [-Wstrict-prototypes] ../../xorg-server-1.20.1/config/udev.c:126:64: error: implicit declaration of function 'minor' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (xf86_find_platform_device_by_devnum(major(devnum), minor(devnum))) ^ I'm guessing this was an existing package error, but it may have been hidden by some linux-headers behavior (e.g., old linux-headers didn't force you to include <sys/sysmacros.h>, but now that we're rev-bumping linux-headers again, rebuilds are uncovering the error?). This CL is in most (?) of the failing runs: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1324989
,
Nov 13
https://chromium-review.googlesource.com/1331008 is in flight to fix
,
Nov 13
CL:1331008 is now in.
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3840bbfb45d2e0a0deb7491f4aabd914ae0a677c commit 3840bbfb45d2e0a0deb7491f4aabd914ae0a677c Author: Manoj Gupta <manojgupta@google.com> Date: Thu Nov 29 05:01:52 2018 xwayland: Update local sysmacros patch from upstream. Upstream patch link: https://gitlab.freedesktop.org/xorg/xserver/commit/82f8cf8990009f6cac567814dd6b7fd41cfad82d BUG= chromium:904709 TEST=emerge-tael xwayland works. Change-Id: I29ebd07430dcb11cb03f5fc31d80382d13fb6610 Reviewed-on: https://chromium-review.googlesource.com/1334790 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/3840bbfb45d2e0a0deb7491f4aabd914ae0a677c/x11-base/xwayland/xwayland-1.20.1-r2.ebuild [modify] https://crrev.com/3840bbfb45d2e0a0deb7491f4aabd914ae0a677c/x11-base/xwayland/files/0001-xwayland-sysmacros.patch |
|||
►
Sign in to add a comment |
|||
Comment 1 by briannorris@chromium.org
, Nov 13