kkhorimoto: Is there an update here? First M72 beta is this Wednesday.

I've finished a fix locally, but am unable to upload/land it due to Issue 912711.  Marking as blocked on that bug until I can upload later.

crrev.com/c/1371082

Kariah, this fix needs tobe merged into M72? We are blocked by this bug for M72 beta qualification as of now (12/12).

In speaking with kkhorimoto offline yesterday, he was planning to merge this. As long as this is not a product issue, it will not block beta this week.

kkhorimoto: Please let us know if this was merged and if there is a product issue here.

crrev.com/c/1371082 got blocked in the CQ yesterday due to timeout issues.  I just put it in the CQ again now; I'll request merge when it's landed.

At this point, we would need to trigger a new beta build or wait until EOD to send beta to Apple. I'm okay if you just land this and merge today and it will make next week's beta.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85d468063100a8839483270aad4a7845fc705b3a

commit 85d468063100a8839483270aad4a7845fc705b3a
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Wed Dec 12 19:28:26 2018

[iOS] Move pdfs below headers when first loaded on iOS 11.

On iOS 12, resetting the WKScrollView.contentInset at the start of the
navigation pushes the content to {0, -contentInset.top}.  On iOS 11,
this does not occur.  This CL updates FullscreenWebStateObserver to
push the content below the toolbar the firs time a NavigationItem is
loaded with the shouldUseViewContentInset property set to YES.

This CL also updates MoveContentHelowHeader() to use the current top
toolbar inset rather than progress * extended toolbar height.  The
previous value was only working correctly because the function was
only called with a progress value of 1.0.

This CL re-enables FullscreenTestCase.testLongPDFInitialState, as
the behavior being tested is now fixed.

Bug:  904694 ,  903247 
Change-Id: I134461e16054846a211a5476dd5a6694bd709002
Reviewed-on: https://chromium-review.googlesource.com/c/1371082
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615997}
[modify] https://crrev.com/85d468063100a8839483270aad4a7845fc705b3a/ios/chrome/browser/ui/fullscreen/fullscreen_content_adjustment_util.mm
[modify] https://crrev.com/85d468063100a8839483270aad4a7845fc705b3a/ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm
[modify] https://crrev.com/85d468063100a8839483270aad4a7845fc705b3a/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_list_observer_unittest.mm
[modify] https://crrev.com/85d468063100a8839483270aad4a7845fc705b3a/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer.mm

Approved=>Requested

This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sorry, requested for the wrong milestone!

This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approved.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed4acaf3500449e78001fff77e6062ecadd6255c

commit ed4acaf3500449e78001fff77e6062ecadd6255c
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Mon Dec 17 21:37:53 2018

[iOS] Move pdfs below headers when first loaded on iOS 11.

On iOS 12, resetting the WKScrollView.contentInset at the start of the
navigation pushes the content to {0, -contentInset.top}.  On iOS 11,
this does not occur.  This CL updates FullscreenWebStateObserver to
push the content below the toolbar the firs time a NavigationItem is
loaded with the shouldUseViewContentInset property set to YES.

This CL also updates MoveContentHelowHeader() to use the current top
toolbar inset rather than progress * extended toolbar height.  The
previous value was only working correctly because the function was
only called with a progress value of 1.0.

This CL re-enables FullscreenTestCase.testLongPDFInitialState, as
the behavior being tested is now fixed.

Bug:  904694 ,  903247 
Change-Id: I134461e16054846a211a5476dd5a6694bd709002
Reviewed-on: https://chromium-review.googlesource.com/c/1371082
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615997}(cherry picked from commit 85d468063100a8839483270aad4a7845fc705b3a)
Reviewed-on: https://chromium-review.googlesource.com/c/1381132
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#407}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/ed4acaf3500449e78001fff77e6062ecadd6255c/ios/chrome/browser/ui/fullscreen/fullscreen_content_adjustment_util.mm
[modify] https://crrev.com/ed4acaf3500449e78001fff77e6062ecadd6255c/ios/chrome/browser/ui/fullscreen/fullscreen_egtest.mm
[modify] https://crrev.com/ed4acaf3500449e78001fff77e6062ecadd6255c/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_list_observer_unittest.mm
[modify] https://crrev.com/ed4acaf3500449e78001fff77e6062ecadd6255c/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer.mm

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/ed4acaf3500449e78001fff77e6062ecadd6255c

Commit: ed4acaf3500449e78001fff77e6062ecadd6255c
Author: kkhorimoto@chromium.org
Commiter: kkhorimoto@chromium.org
Date: 2018-12-17 21:37:53 +0000 UTC

[iOS] Move pdfs below headers when first loaded on iOS 11.

On iOS 12, resetting the WKScrollView.contentInset at the start of the
navigation pushes the content to {0, -contentInset.top}.  On iOS 11,
this does not occur.  This CL updates FullscreenWebStateObserver to
push the content below the toolbar the firs time a NavigationItem is
loaded with the shouldUseViewContentInset property set to YES.

This CL also updates MoveContentHelowHeader() to use the current top
toolbar inset rather than progress * extended toolbar height.  The
previous value was only working correctly because the function was
only called with a progress value of 1.0.

This CL re-enables FullscreenTestCase.testLongPDFInitialState, as
the behavior being tested is now fixed.

Bug:  904694 ,  903247 
Change-Id: I134461e16054846a211a5476dd5a6694bd709002
Reviewed-on: https://chromium-review.googlesource.com/c/1371082
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615997}(cherry picked from commit 85d468063100a8839483270aad4a7845fc705b3a)
Reviewed-on: https://chromium-review.googlesource.com/c/1381132
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#407}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}