Touch action may not have a value when processing a gesture event |
||
Issue descriptionThe design doc for the experiments are here: https://docs.google.com/document/d/1bSv_qNsLLnpXImuH7sHa6D3R_0GdDYkTiNjxso8Rgxo/edit#heading=h.jvxrm66og6z0
,
Dec 20
Recently with compositor touch action study enabled, it seems that both allowed_touch_action_ and white_listed_touch_action_ could have no value when it is here: https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/touch_action_filter.cc?q=touchactionfilter&sq=package:chromium&dr=CSs&l=140
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0aeeec3f9282484094cd927cb484929e2f50f630 commit 0aeeec3f9282484094cd927cb484929e2f50f630 Author: Xida Chen <xidachen@chromium.org> Date: Thu Jan 10 18:27:18 2019 [CompositorTouchAction] DumpWithoutCrashing at GSB In the current code, we do DumpWithoutCrashing for every gesture when the "CompositorTouchAction" study is enabled and that the white listed touch action doesn't have value. This clears the gesture sequence history and doesn't provide enough info. This CL changes the place of DumpWithoutCrashing to be at GSB. With this, we should have the history of gesture sequence. Bug: 904648 Change-Id: I7707fd881e2ccf56c3d646f6310c68d14534b197 Reviewed-on: https://chromium-review.googlesource.com/c/1405289 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#621650} [modify] https://crrev.com/0aeeec3f9282484094cd927cb484929e2f50f630/content/browser/renderer_host/input/touch_action_filter.cc
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edabab55d7f4c7705e708723c39780458a5adc4d commit edabab55d7f4c7705e708723c39780458a5adc4d Author: Xida Chen <xidachen@chromium.org> Date: Mon Jan 14 16:54:24 2019 [Debugging] Add DumpWithoutCrash in more cases In this previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1405289, we added DumpWithoutCrash in GestureScrollBegin. It was in canary for 2 versions and there are only 2 reports. This CL adds DumpWithoutCrash in all the cases where it could crash: GestureScrollBegin, GestureScrollUpdate, GestureTapUnconfirmed and hope that we can gather more info. Bug: 904648 Change-Id: Iabaf43e4fb5375801ddef4fda8968f47d0c6cc00 Reviewed-on: https://chromium-review.googlesource.com/c/1409402 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#622480} [modify] https://crrev.com/edabab55d7f4c7705e708723c39780458a5adc4d/content/browser/renderer_host/input/touch_action_filter.cc
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5461506aa9c494f631d46b633800e604e262f80c commit 5461506aa9c494f631d46b633800e604e262f80c Author: Xida Chen <xidachen@chromium.org> Date: Thu Jan 17 20:12:46 2019 Set touch action auto at GestureTapDown if it has no value It seems that the white listed touch action could have no value at GestureTapDown. This CL sets it to Auto so that the browser won't crash at GestureScrollBegin. We will monitor crashes to check whether this actually solves the problem or not. Bug: 904648 Change-Id: I533be7fea58c9807f049e8431c752e21f1deec79 Reviewed-on: https://chromium-review.googlesource.com/c/1418116 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#623816} [modify] https://crrev.com/5461506aa9c494f631d46b633800e604e262f80c/content/browser/renderer_host/input/touch_action_filter.cc
,
Yesterday
(34 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0188f039c81ebea331c806f043435af20ea02cdb commit 0188f039c81ebea331c806f043435af20ea02cdb Author: Xida Chen <xidachen@chromium.org> Date: Mon Jan 21 21:09:04 2019 [Debugging] Add debugging instrumentation in TouchActionFilter This Cl adds more debugging strings in the TouchActionFilter, to collect more info at DumpWithoutCrashing. Bug: 904648 Change-Id: I5d524043efb6239c80d3a8e80db3ba3efc4eec59 Reviewed-on: https://chromium-review.googlesource.com/c/1425558 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#624675} [modify] https://crrev.com/0188f039c81ebea331c806f043435af20ea02cdb/content/browser/renderer_host/input/touch_action_filter.cc |
||
►
Sign in to add a comment |
||
Comment 1 by xidac...@chromium.org
, Nov 13