New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment
link

Issue 904641: Demo Mode Offline Resources component

Reported by michae...@chromium.org, Nov 13 Project Member

Issue description

Tracking bug for creating the Demo Mode Offline Resources component and loading it from Chrome.

The Offline Resources component is similar to the "online" Demo Mode Resources component, but includes additional resources that need to be preinstalled for offline-enrolled Demo Mode.

The Offline Resources component is complicated by the need for additional per-board resources, like the Highlights app. We'll have multiple versions of this component: some for boards like nocturne and eve, and others for generic x86 or arm boards, meaning burdensome maintenance. The DLC project will simplify that work, hopefully soon.
 

Comment 1 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe40bbc7fa3933ad3e3536307db41b306f709312

commit fe40bbc7fa3933ad3e3536307db41b306f709312
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Thu Nov 15 01:39:32 2018

Move Demo Resources logic to new class

Creates the DemoResources class, removing the nitty-gritty details of
component loading from the global DemoSession instance.

This will make it simpler to update the offline-enrolled mode to use the
offline version of the Demo Mode Resources component. It will also allow
us to check for the existence of Demo Mode resources without starting a
a DemoSession, eg from OOBE.

DemoResources avoids using the term "offline resources" except in the
context of the preinstalled resources used in offline-enrolled Demo
Mode. General Demo Mode resources will just be called "Demo Resources"
or similar.

A follow-up change will update calls to
DemoSession::EnsureOfflineResourcesLoaded() to instead call a similar
function on DemoResources.

Bug:  904641 
Change-Id: Ia931721511fac4efb9e796052bd760a87c952be9
Reviewed-on: https://chromium-review.googlesource.com/c/1333112
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608213}
[modify] https://crrev.com/fe40bbc7fa3933ad3e3536307db41b306f709312/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/fe40bbc7fa3933ad3e3536307db41b306f709312/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/fe40bbc7fa3933ad3e3536307db41b306f709312/chrome/browser/chromeos/login/demo_mode/demo_extensions_external_loader.cc
[modify] https://crrev.com/fe40bbc7fa3933ad3e3536307db41b306f709312/chrome/browser/chromeos/login/demo_mode/demo_mode_resources_remover.cc
[modify] https://crrev.com/fe40bbc7fa3933ad3e3536307db41b306f709312/chrome/browser/chromeos/login/demo_mode/demo_mode_test_helper.cc
[add] https://crrev.com/fe40bbc7fa3933ad3e3536307db41b306f709312/chrome/browser/chromeos/login/demo_mode/demo_resources.cc
[add] https://crrev.com/fe40bbc7fa3933ad3e3536307db41b306f709312/chrome/browser/chromeos/login/demo_mode/demo_resources.h
[add] https://crrev.com/fe40bbc7fa3933ad3e3536307db41b306f709312/chrome/browser/chromeos/login/demo_mode/demo_resources_unittest.cc
[modify] https://crrev.com/fe40bbc7fa3933ad3e3536307db41b306f709312/chrome/browser/chromeos/login/demo_mode/demo_session.cc
[modify] https://crrev.com/fe40bbc7fa3933ad3e3536307db41b306f709312/chrome/browser/chromeos/login/demo_mode/demo_session.h
[modify] https://crrev.com/fe40bbc7fa3933ad3e3536307db41b306f709312/chrome/browser/chromeos/login/demo_mode/demo_session_unittest.cc
[modify] https://crrev.com/fe40bbc7fa3933ad3e3536307db41b306f709312/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/fe40bbc7fa3933ad3e3536307db41b306f709312/chrome/browser/chromeos/login/session/chrome_session_manager.cc

Comment 2 by bugdroid1@chromium.org, Jan 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e

commit f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Sat Jan 12 05:44:54 2019

Demo Mode: Preload offline resources during setup

Demo Mode setup should attempt to load offline resources at the network
screen, so that we only offer Offline Demo Mode as an option when the
offline resources dm-verity image actually exists.

This CL updates the preinstalled offline resources image location
(offline-demo-mode-resources) and changes the network screen to wait for
the resources to be mounted before showing the offline Demo Mode option.

Bug:  904641 
Change-Id: I7a38fbb5b4a2c1c7ad28f9ef0945a2fb7cd09259
Reviewed-on: https://chromium-review.googlesource.com/c/1403181
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622293}
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/demo_mode/demo_mode_resources_remover_unittest.cc
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/demo_mode/demo_mode_test_helper.cc
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/demo_mode/demo_mode_test_helper.h
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/demo_mode/demo_resources.cc
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/demo_mode/demo_resources.h
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/demo_mode/demo_resources_unittest.cc
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/demo_mode/demo_session_unittest.cc
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/demo_mode/demo_setup_browsertest.cc
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.h
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/screens/mock_network_screen.h
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/screens/network_screen.cc
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/screens/network_screen.h
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/screens/network_screen_view.h
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/resources/chromeos/login/oobe_network.js
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/resources/chromeos/login/oobe_screen_network.js
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
[modify] https://crrev.com/f99c9bcbdf30938b2c08128a1c96ea0c7fb2378e/chrome/browser/ui/webui/chromeos/login/network_screen_handler.h

Comment 3 by bugdroid1@chromium.org, Jan 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/780fe7c91dd70b803fe1ee8077666e172b3c9346

commit 780fe7c91dd70b803fe1ee8077666e172b3c9346
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Sun Jan 13 15:10:19 2019

cros_component: use component name as key

Use the component name as the key instead of the package name.
This enables a one-to-many relation of one package to multiple
components.

Demo Mode will use the demo_mode_resources package for both
the online and offline demo mode resources components, since
they only differ in which files are included.

BUG= chromium:904641 
TEST=run build_component.py normally
Change-Id: I864ac8cc8fe70534122d85cf8f3d44358adfd994
Reviewed-on: https://chromium-review.googlesource.com/1394260
Commit-Ready: Michael Giuffrida <michaelpg@chromium.org>
Tested-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>

[modify] https://crrev.com/780fe7c91dd70b803fe1ee8077666e172b3c9346/cros_component/build_component.py
[modify] https://crrev.com/780fe7c91dd70b803fe1ee8077666e172b3c9346/cros_component/cros_components.json

Comment 4 by bugdroid1@chromium.org, Jan 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0493c13afe0866134a3309f7495b1cad47b5a047

commit 0493c13afe0866134a3309f7495b1cad47b5a047
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Sun Jan 13 15:10:19 2019

cros_component: Add offline_demo_mode_resources

Adds a component config for the Offline Demo Mode Resources
component.

This component is built from the same demo_mode_resources package as the
regular Demo Mode Resources component but includes additional files
necessary for setting up Demo Mode while offline.

It will live at gs://chrome-component-offline-demo-mode.

BUG= chromium:904641 
TEST=Build offline_demo_mode_resources (requires patching in
     another CL to create the offline manifest)
Change-Id: I710386667ef614d1d61a131665d71289763b2184
Reviewed-on: https://chromium-review.googlesource.com/1395044
Commit-Ready: Michael Giuffrida <michaelpg@chromium.org>
Tested-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>

[modify] https://crrev.com/0493c13afe0866134a3309f7495b1cad47b5a047/cros_component/cros_components.json

Comment 5 by bugdroid1@chromium.org, Jan 15

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f40ad2741b7a65e0ea8e9bd8491b91bfbfbb0bd7

commit f40ad2741b7a65e0ea8e9bd8491b91bfbfbb0bd7
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Wed Jan 16 09:46:54 2019

installer: Update demo mode resources directory

Update the preinstalled demo mode resources directory location to
refer to the correct component in the cros-components directory.

BUG= chromium:904641 
TEST=manual: build with demo mode resources and install

Change-Id: Ib93d240da113ae38f74fdfd1fedf9247e80957ba
Reviewed-on: https://chromium-review.googlesource.com/1413500
Commit-Ready: Michael Giuffrida <michaelpg@chromium.org>
Tested-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>

[modify] https://crrev.com/f40ad2741b7a65e0ea8e9bd8491b91bfbfbb0bd7/installer/chromeos-install

Comment 7 by michae...@chromium.org, Jan 19

Status: Fixed (was: Started)

Sign in to add a comment