New issue
Advanced search Search tips

Issue 904629 link

Starred by 1 user

Issue metadata

Status: Unconfirmed
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Better handle reverts of bad recipe engine CLs

Project Member Reported by martiniss@chromium.org, Nov 13

Issue description

Context is   bug 903523 

I reverted the offending CL, but I also reverted the roll into tools/build which contained that CL. The recipe roller dutifully noticed that there was a trivial roll it could perform containing the bad CL, and re-landed the roll I had reverted, before landing my revert of the original CL.

I'm not exactly sure what the right solution is to the situation I was in. Should I have not touched the roll? Manually reverted? Manually rolled after the revert of the problematic CL landed?

I also think we should document this in the description of a recipe roll CL.
 

Sign in to add a comment