New issue
Advanced search Search tips

Issue 904626 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add recipe tester to test recipe engine CLs, so they don't break chromium builds

Project Member Reported by martiniss@chromium.org, Nov 13

Issue description

Context is  bug 903523 .

I see two main options.

1. Add a builder to the recipe engine CQ, similar to https://ci.chromium.org/p/infra/builders/luci.infra.try/Build%20Recipes%20Tester, which runs a chromium recipe with the recipe engine CL.

2. Make the existing builder run on changes to recipes.cfg. Currently, the recipes.py analyze command doesn't take into account changes to recipes.cfg, which is why the Build Recipes Tester does nothing when run on recipe rolls (https://ci.chromium.org/p/infra/builders/luci.infra.try/Build%20Recipes%20Tester/b8930280228017517360 is a sample recipe roll CL).

I worry about #2, because it would mean a roll would sit there for 40-ish minutes before failing, and then the author would have to revert the upstream CL, which has already rolled? Maybe those concerns aren't valid?
 
Labels: -Pri-3 Pri-2
Cc: -iannucci@chromium.org
Owner: iannu...@google.com
Status: Assigned (was: Untriaged)
Assigning to Robbie so he can decide what to do/triage.
Option 2 is the correct behavior; if you want to test something in a downstream repo when accepting upstream rolls, you should have the CQ for the downstream repo reject bad upstream CLs (just like we do for all the other rollers).

Having an optional trybot upstream would be a nice bonus, if it's not obvious how to make changes upstream without breaking downstream.
Cc: iannu...@google.com
Owner: martiniss@chromium.org
that said, I believe that you've already created this builder in build.git?

Comment 5 by martiniss@chromium.org, Jan 17 (5 days ago)

Status: Fixed (was: Assigned)
This is... done, right?

Comment 6 by iannu...@google.com, Jan 17 (5 days ago)

yop

Sign in to add a comment