New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 904609 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Allow e2e tests to ignore wired connection when scanning for host for tethering host

Project Member Reported by jordynass@google.com, Nov 12

Issue description

Our CrOS e2e tethering tests are caught in a Catch-22 where they can only test the automatic host scanning functionality without an ethernet connection but they are only deployed with an ethernet connection.

The simplest solution is to provide a runtime flag when deploying the test that tells the scan to ignore wired connections in its logic.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64b3ce15e2a683b83810753fa3dbc9e7469d345b

commit 64b3ce15e2a683b83810753fa3dbc9e7469d345b
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Tue Nov 13 03:00:51 2018

[CrOS Tether] Allow tests to ignore ethernet during tether host scan

As we try to add new e2e tethering tests, we need a way to make the
host scan occur normally even when there is an ethernet connection
because there's always an ethernet connection to deploy the test.

This CL creates the infrastructure necessary to create a flag to
override the prohibition against searching for a tethering host with an
ethernet connection by gating it on booleans called
ignore_wired_networks_

-----

Testing:

I manually tested that this change causes the tethering notification to
appear when the user logs in with an ethernet connection but no wifi
connection. For comparison, I also tested that logging in with a wifi
network does not cause the notification to appear.

Bug: 904609
Change-Id: I7406274cd159ae2b18ad6a22ca90cba76b98dbad
Reviewed-on: https://chromium-review.googlesource.com/c/1332693
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607461}
[modify] https://crrev.com/64b3ce15e2a683b83810753fa3dbc9e7469d345b/chromeos/components/tether/host_scan_scheduler_impl.cc
[modify] https://crrev.com/64b3ce15e2a683b83810753fa3dbc9e7469d345b/chromeos/components/tether/host_scan_scheduler_impl.h
[modify] https://crrev.com/64b3ce15e2a683b83810753fa3dbc9e7469d345b/chromeos/components/tether/host_scanner_impl.cc
[modify] https://crrev.com/64b3ce15e2a683b83810753fa3dbc9e7469d345b/chromeos/components/tether/host_scanner_impl.h

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/306f652506c5622c732f3b61e0d000074078b877

commit 306f652506c5622c732f3b61e0d000074078b877
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Wed Nov 14 02:38:31 2018

[CrOS Tether] Add chromeos switch for ignoring wired connections

This adds a chromeos switch to allow tether host scans to occur in
spite of ethernet connections. This is a followup to CL 1332693.

-----

TESTING:

I confirmed manually that turning off the switch prevented a host scan
when ethernet is plugged in while turning it on allowed the 'tether
host found' notification.


Bug: 904609
Change-Id: If0938796841228415c72fb6ccc9b0a52c3d64786
Reviewed-on: https://chromium-review.googlesource.com/c/1334206
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607878}
[modify] https://crrev.com/306f652506c5622c732f3b61e0d000074078b877/chromeos/chromeos_switches.cc
[modify] https://crrev.com/306f652506c5622c732f3b61e0d000074078b877/chromeos/chromeos_switches.h
[modify] https://crrev.com/306f652506c5622c732f3b61e0d000074078b877/chromeos/components/tether/host_scan_scheduler_impl.cc
[modify] https://crrev.com/306f652506c5622c732f3b61e0d000074078b877/chromeos/components/tether/host_scan_scheduler_impl.h
[modify] https://crrev.com/306f652506c5622c732f3b61e0d000074078b877/chromeos/components/tether/host_scanner_impl.cc
[modify] https://crrev.com/306f652506c5622c732f3b61e0d000074078b877/chromeos/components/tether/host_scanner_impl.h

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Comment 4 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 5 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry

Sign in to add a comment