Allow e2e tests to ignore wired connection when scanning for host for tethering host |
||||
Issue descriptionOur CrOS e2e tethering tests are caught in a Catch-22 where they can only test the automatic host scanning functionality without an ethernet connection but they are only deployed with an ethernet connection. The simplest solution is to provide a runtime flag when deploying the test that tells the scan to ignore wired connections in its logic.
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/306f652506c5622c732f3b61e0d000074078b877 commit 306f652506c5622c732f3b61e0d000074078b877 Author: Jordy Greenblatt <jordynass@chromium.org> Date: Wed Nov 14 02:38:31 2018 [CrOS Tether] Add chromeos switch for ignoring wired connections This adds a chromeos switch to allow tether host scans to occur in spite of ethernet connections. This is a followup to CL 1332693. ----- TESTING: I confirmed manually that turning off the switch prevented a host scan when ethernet is plugged in while turning it on allowed the 'tether host found' notification. Bug: 904609 Change-Id: If0938796841228415c72fb6ccc9b0a52c3d64786 Reviewed-on: https://chromium-review.googlesource.com/c/1334206 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#607878} [modify] https://crrev.com/306f652506c5622c732f3b61e0d000074078b877/chromeos/chromeos_switches.cc [modify] https://crrev.com/306f652506c5622c732f3b61e0d000074078b877/chromeos/chromeos_switches.h [modify] https://crrev.com/306f652506c5622c732f3b61e0d000074078b877/chromeos/components/tether/host_scan_scheduler_impl.cc [modify] https://crrev.com/306f652506c5622c732f3b61e0d000074078b877/chromeos/components/tether/host_scan_scheduler_impl.h [modify] https://crrev.com/306f652506c5622c732f3b61e0d000074078b877/chromeos/components/tether/host_scanner_impl.cc [modify] https://crrev.com/306f652506c5622c732f3b61e0d000074078b877/chromeos/components/tether/host_scanner_impl.h
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Nov 13