New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 904604 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

The version of pip shipped with depot_tools on Windows is too old

Project Member Reported by gab@chromium.org, Nov 12

Issue description

depot_tools/my_activity.py requires the dateutil package on Windows.

I used to be able to run

$ python -m pip install python-dateutil

but that never results in an SSL error.

As described @ 
  https://github.com/pypa/pip/issues/5236
and
 https://stackoverflow.com/questions/49748063/pip-install-fails-for-every-package-could-not-find-a-version-that-satisfies/49748494#49748494

old versions of pip no longer work because the deprecation of old TLS certificates for python.org sites.


depot_tools's pip is @ version 1.4.1

$ python -m pip -V
pip 1.4.1 from c:\src\depot_tools\win_tools-2_7_6_bin\python\bin\lib\site-packages (python 2.7)
 
Depot tools should not be in business of shipping pip. If myactivity or any other script there needs Python libraries, declaring them as vpython dependencies is the right way to go.
What's a vpython dependency? Is this something every dev needs to set up?
Cc: ajp@chromium.org
Components: -Infra>Git
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
assigned to tandrii@ since he has the knowledge and followed up on this already
Components: -Infra Infra>SDK
Cc: iannucci@chromium.org tandrii@chromium.org
Labels: -Pri-1 Pri-3
Owner: ----
Status: Available (was: Assigned)
It's a file like this https://cs.chromium.org/chromium/src/.vpython?q=vpython&sq=package:chromium&dr=C&l=1 

vpython will ensure that before a script runs, it'll have available python virtual env with exact versions of depenedencies as specified in .vpython file. That's it. One has to create it for script(s) in depot_tools.

my $0.02:
  my_activity is a nice script, I use it and I contributed to it.
  BUT, it shouldn't be supported by Infra as first class depot_tools citizen.
  Ditto for pip.

  Thus, if you really care about my_activity, figure out how to hook .vpython for my_activity (good for everyone) or just manually install missing deps on your workstation.

iannucci@ can probably provide more/better pointers. I personally don't have an idea how much work it takes to provide dedicated .vpython for my_activity w/o potentially breaking other scripts in depot_tools.
Labels: -Infra-Git
vpython would find `my_activite.py.vpython` first, so you could add it that way without affecting anything else.
er, typo: `my_activity.py.vpython`
That said, I'm looking to roll out a new version of python in depot_tools soon.
Will the upcoming version of python have an up-to-date pip?

Le ven. 16 nov. 2018 19 h 13, iannucci via monorail <
monorail+v2.2908284855@chromium.org> a écrit :
Yes (and setuptools and wheel as well)
Awesome, ETA? Shall we make that a blocker? I can deal with no
my_activity.py on my laptop for a few weeks

Le lun. 19 nov. 2018 16 h 04, iannucci via monorail <
monorail+v2.2908284855@chromium.org> a écrit :
I was hoping this week or next but it's a somewhat complicated project, unfortunately, so there's a lot of 'unknown unknowns'
Actually, regardless of that, the right thing to do would be to add a vpython spec and run it with that; that should work with the current versions of python/pip (as well as the future versions of python/pip).

Sign in to add a comment