New issue
Advanced search Search tips

Issue 904598 link

Starred by 1 user
Status: Fixed
Owner:
eroman@chromium.org
Closed: Nov 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add tests that matching of <-loopback> and <local> is case-insensitive

Project Member Reported by eroman@chromium.org, Nov 12 
WinInet recognizes <-loopback> and <local> proxy bypass rules using a case-insensitive comparison (i.e. <LOCAL>, <Local>, <local> are all equivalent).

Whereas Chrome only accepts the lower-case form.

Comment 1 by eroman@chromium.org, Nov 12

Summary: Add tests that matching of <-loopback> and <local> is case-insensitive (was: Matching for <-loopback> and <local> should be case-insensitive)
Actually Chrome does the right thing, we just don't have tests for it :)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d862b6a75ada1ba4c3e78306eb320f2b6d17674

commit 3d862b6a75ada1ba4c3e78306eb320f2b6d17674
Author: Eric Roman <eroman@chromium.org>
Date: Tue Nov 13 01:57:54 2018

Add tests for case-insensitivity when parsing <-loopback> and <local>.

Bug:  904598 
Change-Id: If760623af28051df78e1209df29e412190eb70b6
Reviewed-on: https://chromium-review.googlesource.com/c/1332290
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607430}
[modify] https://crrev.com/3d862b6a75ada1ba4c3e78306eb320f2b6d17674/net/proxy_resolution/proxy_bypass_rules_unittest.cc

Comment 3 by eroman@chromium.org, Nov 13

Status: Fixed (was: Assigned)
►

Sign in to add a comment