Flaky test: fast/css/no-recalc-on-no-op-inline-style-changes.html Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/6566 Test output log: https://chromium-swarm.appspot.com/task?id=41228bbca7f73310 Culprit (70.0% confidence): r607268 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKgAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cy82NTY2L3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gSW50ZWwgR1BVIG9uIE1hYyBvbiBNYWMtMTAuMTIuNi9abUZ6ZEM5amMzTXZibTh0Y21WallXeGpMVzl1TFc1dkxXOXdMV2x1YkdsdVpTMXpkSGxzWlMxamFHRnVaMlZ6TG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20fast/css/no-recalc-on-no-op-inline-style-changes.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKgAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cy82NTY2L3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gSW50ZWwgR1BVIG9uIE1hYyBvbiBNYWMtMTAuMTIuNi9abUZ6ZEM5amMzTXZibTh0Y21WallXeGpMVzl1TFc1dkxXOXdMV2x1YkdsdVpTMXpkSGxzWlMxamFHRnVaMlZ6TG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb0fc8da6655254bddcf03fcd6a9730ad481eb1e commit bb0fc8da6655254bddcf03fcd6a9730ad481eb1e Author: Rune Lillesveen <futhark@chromium.org> Date: Tue Nov 13 09:45:32 2018 Deflake fast/css/no-recalc-on-no-op-inline-style-changes.html The test had an assumption about a style recalc count at a point during loading which was not preceeded by a forced recalc at any point. The result was undefined and it did not test anything useful. Add a forced recalc through offsetTop before the test instead. Bug: 904587 Change-Id: I17d00e017a625ca10f71ebfd3a946266d6ea9ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1332431 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#607536} [modify] https://crrev.com/bb0fc8da6655254bddcf03fcd6a9730ad481eb1e/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/bb0fc8da6655254bddcf03fcd6a9730ad481eb1e/third_party/WebKit/LayoutTests/fast/css/no-recalc-on-no-op-inline-style-changes.html
Comment 1 by dtapu...@chromium.org
, Nov 13