New issue
Advanced search Search tips

Issue 904574 link

Starred by 1 user
Status: Fixed
Owner:
hta@chromium.org
Closed: Nov 21
Cc:
hbos@chromium.org
hta@chromium.org
robertma@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocked on:
issue webrtc:7979


Sign in to add a comment

[WPT] New failures introduced in external/wpt/webrtc by import https://crrev.com/c/1331616

 
WPT import https://crrev.com/c/1331616 introduced new failures in external/wpt/webrtc:

List of new failures:
virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-track-stats.https.html [ Timeout ]
external/wpt/webrtc/RTCPeerConnection-track-stats.https.html [ Timeout ]

This import contains upstream changes from 2f868fae5b43c68e4807f6a4ec9487f13ea39cf4 to 89188af97522b15cfe7ab6cc1c9cdb58007f0967:
webdriver: add stress tests for window manipulation: https://github.com/web-platform-tests/wpt/commit/89188af97522b15cfe7ab6cc1c9cdb58007f0967
webdriver: take 22px window border into account on maximizing: https://github.com/web-platform-tests/wpt/commit/7137e1103bf4ad8a6572601a4980b74b96e4d6b7
webdriver: test scroll behaviour on partially visible elements: https://github.com/web-platform-tests/wpt/commit/6914e48bebf1e85a6cc3162fdf58bff55c7a420a
webdriver: move center_point into helpers: https://github.com/web-platform-tests/wpt/commit/d7c75566e7275bb0be705ca63e67004d0e043f2a
Correct WebRTC getStats WPT to wait for remote stats before comparing: https://github.com/web-platform-tests/wpt/commit/42392b14d1bf3ecba78c24cce7213e714447f3dc [affecting this directory]
Fix up two other instances of ParseError not passing in metadata: https://github.com/web-platform-tests/wpt/commit/b310ad59db6fb7d36789bb00b80037bf6c4439c1
Make sure wptmanifest's ParseError prints out filename and line number when called: https://github.com/web-platform-tests/wpt/commit/ef4c0dc64c7772076ed98af32a57a8ce652b3e31
HTMLScriptElement text attributes modified to accept TrustedTypes: https://github.com/web-platform-tests/wpt/commit/860091dbc783a678f128328646a519d9891f0838
Read and write files in binary mode: https://github.com/web-platform-tests/wpt/commit/d0c94e610154d3a7cdf1f2882a7ac74d4dfe3114
Update the unit tests: https://github.com/web-platform-tests/wpt/commit/dfbb0fd0cba67a8b0ea261fcfaaa805fe6ed7f03
Add unit tests for wrapper handlers in tools/serve: https://github.com/web-platform-tests/wpt/commit/2225031efc850d3b87ea33210b79730b466f5c50
Set orphans and widows to 1 in new multicol test.: https://github.com/web-platform-tests/wpt/commit/0d4f539f5d4c7272c9fe07bd204674b207e4a979

Comment 1 by hbos@chromium.org, Nov 14

Status: Available (was: Untriaged)
They are timing out because of this:
https://github.com/web-platform-tests/wpt/commit/42392b14d1bf3ecba78c24cce7213e714447f3dc

We do not have localId and remoteId because we have not implemented RTCRemote*.

Comment 2 by hbos@chromium.org, Nov 14

Components: -Blink>WebRTC Blink>WebRTC>PeerConnection

Comment 3 by hta@chromium.org, Nov 14

Blockedon: webrtc:7979
Seems a bit strange to time out because of a missing field.
Still, making solution depend on remote stats.

Comment 4 by hta@chromium.org, Nov 19

Owner: hta@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1101c25681c2051acda608febe69fa2913291eb

commit b1101c25681c2051acda608febe69fa2913291eb
Author: Harald Alvestrand <hta@chromium.org>
Date: Wed Nov 21 12:27:44 2018

Prevent timeout when remote stats are not implemented

This prevents a failure in RTCP messsaging from masking
other failures. It's up to other tests to actually
verify that RTCP stats have been delivered.

Bug:  904574 
Change-Id: Ie641d5275372b4c10ad5fa3a39ae38c36f974482
Reviewed-on: https://chromium-review.googlesource.com/c/1341510
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610010}
[modify] https://crrev.com/b1101c25681c2051acda608febe69fa2913291eb/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/b1101c25681c2051acda608febe69fa2913291eb/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-helper.js

Comment 6 by hta@chromium.org, Nov 21

Status: Fixed (was: Started)
►

Sign in to add a comment