New issue
Advanced search Search tips

Issue 904564 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add DemoMode.UniqueAppsLaunched UMA stat

Project Member Reported by michaelpg@google.com, Nov 12

Issue description

Add an UMA metric to indicate how many unique apps were launched in a Demo Mode session.

For example:

1. Enroll a device in Demo Mode (press Ctrl+Alt+D at OOBE)
2. Start a demo session
3. Launch Highlights app (automatically)
4. Launch Chrome
5. Launch Infinite Painter
6. Close Infinite Painter
7. Launch Keep
8. Launch Infinite Painter
9. Exit the session

Expected: DemoMode.UniqueAppsLaunched logs 4 unique apps opened (counting Chrome as an app)

We currently use DemoSessionMetricsRecorder to record the active app over time. We could reuse this to listen to app launch events and keep track of how many unique apps are launched.
 
Cc: wzang@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92ee9e829b17958365047c745caa48545424f325

commit 92ee9e829b17958365047c745caa48545424f325
Author: Danan S <danan@chromium.org>
Date: Thu Jan 03 00:10:47 2019

Revert "Added UMA metric to count unique apps launched during Demo Mode."

This reverts commit e775e11093ce59910577041d1514ee1a74f18c1b.

Reason for revert: This is inconsistently crashing demo mode
when Android apps are launched on certain devices.

Original change's description:
> Added UMA metric to count unique apps launched during Demo Mode.
>
> Bug: 904564
> Change-Id: I653438bf5244bc98bcb742d9d986b4ea2bd4b40a
> Reviewed-on: https://chromium-review.googlesource.com/c/1334563
> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609961}

TBR=oshima@chromium.org,michaelpg@chromium.org,bcwhite@chromium.org,danan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 917156
Change-Id: I7e8d88541ad5f74fda720425c05816f48e4ba4a8
Reviewed-on: https://chromium-review.googlesource.com/c/1387953
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Danan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619542}
[modify] https://crrev.com/92ee9e829b17958365047c745caa48545424f325/ash/metrics/demo_session_metrics_recorder.cc
[modify] https://crrev.com/92ee9e829b17958365047c745caa48545424f325/ash/metrics/demo_session_metrics_recorder.h
[modify] https://crrev.com/92ee9e829b17958365047c745caa48545424f325/ash/metrics/demo_session_metrics_recorder_unittest.cc

Labels: M-73
Status: Assigned (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 8

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1773c1d4c775b6a75aa7816be11a91a84d924afb

commit 1773c1d4c775b6a75aa7816be11a91a84d924afb
Author: Danan S <danan@chromium.org>
Date: Tue Jan 08 18:00:25 2019

Revert "Added UMA metric to count unique apps launched during Demo Mode."

This reverts commit e775e11093ce59910577041d1514ee1a74f18c1b.

Reason for revert: This is inconsistently crashing demo mode
when Android apps are launched on certain devices.

Original change's description:
> Added UMA metric to count unique apps launched during Demo Mode.
>
> Bug: 904564
> Change-Id: I653438bf5244bc98bcb742d9d986b4ea2bd4b40a
> Reviewed-on: https://chromium-review.googlesource.com/c/1334563
> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609961}

TBR=oshima@chromium.org,michaelpg@chromium.org,bcwhite@chromium.org,danan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 917156
Change-Id: I7e8d88541ad5f74fda720425c05816f48e4ba4a8
Reviewed-on: https://chromium-review.googlesource.com/c/1387953
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Danan S <danan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#619542}(cherry picked from commit 92ee9e829b17958365047c745caa48545424f325)
Reviewed-on: https://chromium-review.googlesource.com/c/1394907
Cr-Commit-Position: refs/branch-heads/3626@{#609}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/1773c1d4c775b6a75aa7816be11a91a84d924afb/ash/metrics/demo_session_metrics_recorder.cc
[modify] https://crrev.com/1773c1d4c775b6a75aa7816be11a91a84d924afb/ash/metrics/demo_session_metrics_recorder.h
[modify] https://crrev.com/1773c1d4c775b6a75aa7816be11a91a84d924afb/ash/metrics/demo_session_metrics_recorder_unittest.cc

Sign in to add a comment