Introduce browser tests running in Service Manager only mode. |
||
Issue descriptionAdd browser tests that are running without starting the full browser. We could start with running a test that starts service manager only. Then, add more tests that start download service and network service after the service manager starts. We could starts from Android browser tests which can create a service with the option to not start the full browser. An example is ChromeBackgroundServiceTest: https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0440b5499635f2594cfbb421b084780ccb3b76f5 commit 0440b5499635f2594cfbb421b084780ccb3b76f5 Author: Xi Han <hanxi@google.com> Date: Wed Nov 28 21:24:41 2018 Add browser tests for running in service manager only mode. This is the first patch that adds tests that start Service Manager and run without full browser starts. Bug: 904549 Change-Id: I713aa68ba5ce7af11075a73a4ff52303b3c013ec Reviewed-on: https://chromium-review.googlesource.com/c/1332259 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611872} [modify] https://crrev.com/0440b5499635f2594cfbb421b084780ccb3b76f5/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java [modify] https://crrev.com/0440b5499635f2594cfbb421b084780ccb3b76f5/chrome/android/java/src/org/chromium/chrome/browser/init/ServiceManagerStartupUtils.java [modify] https://crrev.com/0440b5499635f2594cfbb421b084780ccb3b76f5/chrome/android/java_sources.gni [add] https://crrev.com/0440b5499635f2594cfbb421b084780ccb3b76f5/chrome/android/javatests/src/org/chromium/chrome/browser/ServicificationBackgroundServiceTest.java
,
Nov 30
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c9e715797704e6eed236eef16d2daf92c44fe8b commit 2c9e715797704e6eed236eef16d2daf92c44fe8b Author: Xi Han <hanxi@google.com> Date: Tue Dec 11 21:26:50 2018 Add a checks that full browser doesn't started in ServicificationBackgroundServiceTest. Add a check to make sure the background tasks are running in ServiceManager only mode and the full browser doesn't start. Otherwise, if the test falls back to start the full browser, it won't be able to detect any failure that happens only in the ServiceManager mode. To do this, we plumb the startup result from the native to Java via the callback when ServiceManager started. The callback will tells Java if the full browser is starting. Bug: 904549 Change-Id: I39d39166269fa0fcebf54b9d8ece3b6c761a223a Reviewed-on: https://chromium-review.googlesource.com/c/1363369 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615666} [modify] https://crrev.com/2c9e715797704e6eed236eef16d2daf92c44fe8b/chrome/android/javatests/src/org/chromium/chrome/browser/ServicificationBackgroundService.java [modify] https://crrev.com/2c9e715797704e6eed236eef16d2daf92c44fe8b/chrome/android/javatests/src/org/chromium/chrome/browser/ServicificationBackgroundServiceTest.java [modify] https://crrev.com/2c9e715797704e6eed236eef16d2daf92c44fe8b/chrome/android/javatests/src/org/chromium/chrome/browser/download/ServicificationDownloadTest.java [modify] https://crrev.com/2c9e715797704e6eed236eef16d2daf92c44fe8b/content/app/content_main_runner_impl.cc [modify] https://crrev.com/2c9e715797704e6eed236eef16d2daf92c44fe8b/content/public/android/java/src/org/chromium/content/browser/BrowserStartupControllerImpl.java |
||
►
Sign in to add a comment |
||
Comment 1 by hanxi@chromium.org
, Nov 15