New issue
Advanced search Search tips

Issue 904548 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 15
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Downloads Home] Download completed Image still shows in-progress layout on tablets

Project Member Reported by shaktisahu@google.com, Nov 12

Issue description

Steps to reproduce :
1 - Open download home on tablet
2 - Switch to a different tab and download an image
3 - Download a second image
4 - Go to downloads page and observe that the image that was downloaded first shows an in-progress view indefinitely. It should show completed image instead.
5 - Observe that if you refresh the downloads page you get back to correct state
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0197d39377877cf4ca694ce8473c64727c0c0724

commit 0197d39377877cf4ca694ce8473c64727c0c0724
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Tue Nov 13 02:13:15 2018

Download Home : Fixed an issue in the mutator

Fixed a bug in the onItemUpdated of the mutator which was not
propagating the updated item to its internal data structure.

Bug:  904548 
Change-Id: I64298c1aa591709edcf73736e207474fb3b8b062
Reviewed-on: https://chromium-review.googlesource.com/c/1332408
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607443}
[modify] https://crrev.com/0197d39377877cf4ca694ce8473c64727c0c0724/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListMutator.java
[modify] https://crrev.com/0197d39377877cf4ca694ce8473c64727c0c0724/chrome/android/junit/src/org/chromium/chrome/browser/download/home/list/DateOrderedListMutatorTest.java

Labels: Merge-Request-71
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 13

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
Merge approved for 71, branch 3578.
Verified in M72-72.0.3611.0
Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 15

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5949a51ebfd0befdded505293b1cb2961be865cd

commit 5949a51ebfd0befdded505293b1cb2961be865cd
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Thu Nov 15 22:30:50 2018

Download Home : Fixed an issue in the mutator

Fixed a bug in the onItemUpdated of the mutator which was not
propagating the updated item to its internal data structure.

Bug:  904548 
Change-Id: I64298c1aa591709edcf73736e207474fb3b8b062
Reviewed-on: https://chromium-review.googlesource.com/c/1332408
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607443}(cherry picked from commit 0197d39377877cf4ca694ce8473c64727c0c0724)
Reviewed-on: https://chromium-review.googlesource.com/c/1338416
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#709}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/5949a51ebfd0befdded505293b1cb2961be865cd/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListMutator.java
[modify] https://crrev.com/5949a51ebfd0befdded505293b1cb2961be865cd/chrome/android/junit/src/org/chromium/chrome/browser/download/home/list/DateOrderedListMutatorTest.java

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/5949a51ebfd0befdded505293b1cb2961be865cd

Commit: 5949a51ebfd0befdded505293b1cb2961be865cd
Author: shaktisahu@chromium.org
Commiter: shaktisahu@chromium.org
Date: 2018-11-15 22:30:50 +0000 UTC

Download Home : Fixed an issue in the mutator

Fixed a bug in the onItemUpdated of the mutator which was not
propagating the updated item to its internal data structure.

Bug:  904548 
Change-Id: I64298c1aa591709edcf73736e207474fb3b8b062
Reviewed-on: https://chromium-review.googlesource.com/c/1332408
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#607443}(cherry picked from commit 0197d39377877cf4ca694ce8473c64727c0c0724)
Reviewed-on: https://chromium-review.googlesource.com/c/1338416
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#709}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment