New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 904524 link

Starred by 1 user
Status: Fixed
Owner:
█ abenner@google.com
Last visit > 30 days ago
Closed: Nov 16
Cc:
agrieve@chromium.org
estevenson@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Custom ErrorProne checks not running

Project Member Reported by abenner@google.com, Nov 12 
What steps will reproduce the problem?
(1) Modify a java file in a target with ErrorProne enabled that breaks one of the ErrorProne rules in org.chromium.tools.errorprone.plugin
(2) Compile the target

What is the expected result?
The ErrorProne warning should break the build. 

What happens instead?
Target compiles fine and the broken check is ignored.

Comment 1 by abenner@google.com, Nov 12 

After bisecting seems like this CL as the culprit:
https://chromium-review.googlesource.com/c/chromium/src/+/1252006/

Comment 2 by estevenson@chromium.org, Nov 13

Cc: -estevenson@google.com estevenson@chromium.org
Owner: abenner@google.com
Assigning to abenner@ since I believe he has a fix for this
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdb01fcd3bbebb47edb2b9831a0c66e289c2702f

commit bdb01fcd3bbebb47edb2b9831a0c66e289c2702f
Author: Aiden Benner <abenner@google.com>
Date: Thu Nov 15 00:43:36 2018

Fix redundant field initializations

Normally custom ErrorProne checks would catch this,
but they were inadvertently disabled.
In preparation for for re-enabling these custom ErrorProne checks
this CL fixes all the redundant field initializations that have
crept into the codebase.

Trivial mechanical change

TBR=yfriedman@chromium.org

Bug:  904524 
Change-Id: I96a81a1cb3b8c67bc682728aa9035c4757ed319b
Reviewed-on: https://chromium-review.googlesource.com/c/1334188
Commit-Queue: Aiden Benner <abenner@google.com>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608197}
[modify] https://crrev.com/bdb01fcd3bbebb47edb2b9831a0c66e289c2702f/chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedProcessScopeFactory.java
[modify] https://crrev.com/bdb01fcd3bbebb47edb2b9831a0c66e289c2702f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java
[modify] https://crrev.com/bdb01fcd3bbebb47edb2b9831a0c66e289c2702f/chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AnimatedProgressBar.java
[modify] https://crrev.com/bdb01fcd3bbebb47edb2b9831a0c66e289c2702f/chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
[modify] https://crrev.com/bdb01fcd3bbebb47edb2b9831a0c66e289c2702f/chrome/android/java/src/org/chromium/chrome/browser/preferences/NotificationsPreferences.java
[modify] https://crrev.com/bdb01fcd3bbebb47edb2b9831a0c66e289c2702f/chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabCountProvider.java
[modify] https://crrev.com/bdb01fcd3bbebb47edb2b9831a0c66e289c2702f/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
[modify] https://crrev.com/bdb01fcd3bbebb47edb2b9831a0c66e289c2702f/chrome/android/junit/src/org/chromium/chrome/browser/feed/action/FeedActionHandlerTest.java
[modify] https://crrev.com/bdb01fcd3bbebb47edb2b9831a0c66e289c2702f/tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb883dcb2bfd63a4d6d9e50f456ca29b2c2f650e

commit eb883dcb2bfd63a4d6d9e50f456ca29b2c2f650e
Author: Aiden Benner <abenner@google.com>
Date: Thu Nov 15 16:59:00 2018

Fix redundant field initializations in generated JNI wrapper

Normally custom ErrorProne checks would catch this,
but they were inadvertently disabled.
In preparation for for re-enabling these custom ErrorProne checks
this CL removes redundant field initializations in GEN_JNI
(the generated java file that contains proxy native methods).

Bug:  904524 
Change-Id: I2e7b2d93b4ed89d34b236ab9a64dc6c47dcdd17d
Reviewed-on: https://chromium-review.googlesource.com/c/1334093
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>
Cr-Commit-Position: refs/heads/master@{#608403}
[modify] https://crrev.com/eb883dcb2bfd63a4d6d9e50f456ca29b2c2f650e/base/android/jni_generator/java/src/org/chromium/jni_generator/JniProcessor.java
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31880386311dfe27f45914c15def779423d43c02

commit 31880386311dfe27f45914c15def779423d43c02
Author: Aiden Benner <abenner@google.com>
Date: Thu Nov 15 18:09:43 2018

Fix regression where custom ErrorProne checks were not run

Fix bug where all custom ErrorProne checks were not running.
Introduced by:
https://chromium-review.googlesource.com/c/chromium/src/+/1252006/

Changing the jar wildcard from * to *.class excluded metadata
files generated by Autoservice which were needed to load
the custom ErrorProne checks.

This CL reverts that pattern change.

Bug:  904524 
Change-Id: Id452f2d797872eb306fcd52be433128c8835e015
Reviewed-on: https://chromium-review.googlesource.com/c/1331877
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>
Cr-Commit-Position: refs/heads/master@{#608436}
[modify] https://crrev.com/31880386311dfe27f45914c15def779423d43c02/build/android/gyp/jar.py

Comment 6 by abenner@google.com, Nov 16

Status: Fixed (was: Untriaged)
►

Sign in to add a comment