New issue
Advanced search Search tips

Issue 904521 link

Starred by 1 user
Status: Assigned
Owner:
mahmadi@chromium.org
Cc:
sczs@chromium.org
ftirelo@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Save card infobar has broken constraints when displaying

Project Member Reported by mahmadi@chromium.org, Nov 12 
2018-11-12 15:05:40.496620-0500 Chromium[87861:926426] [LayoutConstraints] Unable to simultaneously satisfy constraints.
	Probably at least one of the constraints in the following list is one you don't want. 
	Try this: 
		(1) look at each constraint and try to figure out which you don't expect; 
		(2) find the code that added the unwanted constraint or constraints and fix it. 
(
    "<NSLayoutConstraint:0x60000378eb70 V:|-(16)-[UIView:0x7fccb227f010]   (active, names: '|':UIView:0x7fccb2280e60 )>",
    "<NSLayoutConstraint:0x60000378eb20 UIView:0x7fccb227f010.bottom == UIView:0x7fccb2280e60.bottom - 24   (active)>",
    "<NSLayoutConstraint:0x600003463e30 UIView:0x7fccb2280e60.top == UILayoutGuide:0x600002d1c9a0'UIViewSafeAreaLayoutGuide'.top   (active)>",
    "<NSLayoutConstraint:0x60000346c5a0 V:[UIView:0x7fccb2280e60]-(0)-[UIStackView:0x7fccb2281fe0]   (active)>",
    "<NSLayoutConstraint:0x600003468fa0 UIStackView:0x7fccb2281fe0.bottom == UIStackView:0x7fccaf741d50.top   (active)>",
    "<NSLayoutConstraint:0x600003468e60 V:[UIStackView:0x7fccaf741d50]-(0)-|   (active, names: SaveCardInfobarViewUpload...:0x7fccb226daf0, '|':SaveCardInfobarViewUpload...:0x7fccb226daf0 )>",
    "<NSLayoutConstraint:0x6000034696d0 V:|-(0)-[SaveCardInfobarViewUpload...]   (active, names: SaveCardInfobarViewUpload...:0x7fccb226daf0, '|':UIView:0x7fccb2231250 )>",
    "<NSLayoutConstraint:0x600003469720 SaveCardInfobarViewUpload....bottom == UIView:0x7fccb2231250.bottom   (active, names: SaveCardInfobarViewUpload...:0x7fccb226daf0 )>",
    "<NSLayoutConstraint:0x6000037fe4e0 'UIView-Encapsulated-Layout-Height' UIView:0x7fccb2231250.height == 0   (active)>",
    "<NSLayoutConstraint:0x600003463cf0 'UIViewSafeAreaLayoutGuide-top' V:|-(0)-[UILayoutGuide:0x600002d1c9a0'UIViewSafeAreaLayoutGuide']   (active, names: SaveCardInfobarViewUpload...:0x7fccb226daf0, '|':SaveCardInfobarViewUpload...:0x7fccb226daf0 )>"
)

Will attempt to recover by breaking constraint 
<NSLayoutConstraint:0x60000378eb20 UIView:0x7fccb227f010.bottom == UIView:0x7fccb2280e60.bottom - 24   (active)>
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b34159843baa90cdc93206de623fa89b3c839e15

commit b34159843baa90cdc93206de623fa89b3c839e15
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Nov 13 17:01:51 2018

[AF][IOS] Fixes SaveCardInfoBarView's broken constraints

SaveCardInfoBarView's constraints break while the parent view animates.
This CL fixes that problem by lowering the priority of the constraints on
the SaveCardInfoBarView's bottom anchor while setting up subviews and
restoring it once SaveCardInfoBarView has moved to its superview.

This CL also:
-adds a11y identifiers to subviews for easier debugging.
-sets translatesAutoresizingMaskIntoConstraints to NO where missing.
-removes unnecessary constraints.

Bug: 904521
Change-Id: I99dabdbc83614b881c6af4eaad22c29cc4fd8c08
Reviewed-on: https://chromium-review.googlesource.com/c/1331910
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607623}
[modify] https://crrev.com/b34159843baa90cdc93206de623fa89b3c839e15/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm

Comment 2 by mahmadi@chromium.org, Nov 13

Status: Fixed (was: Started)

Comment 3 by sczs@google.com, Nov 13

Status: Assigned (was: Fixed)
Since this bug is still being used as a TODO for investigation I think we should leave it open. If not it might be confusing and someone might think that the TODO's can be removed. WDYT?

Comment 4 by mahmadi@chromium.org, Nov 13 

SG!
►

Sign in to add a comment