kForceWaveAudio no longer triggering PCMWaveOutAudioOutputStream
Reported by
regoma...@lindenlab.com,
Nov 12
|
||||||
Issue description
Chrome Version : 70.0.3538.77
OS Version: 10.0
URLs (if applicable) : none
Other browsers tested: none
Chromium has a kForceWaveAudio ("force-wave-audio") option that stopped working somewhere between releases 53 and 62. We confirmed that IsSupportedInternal() returns false when the option is present:
static bool IsSupportedInternal() {
// It is possible to force usage of WaveXxx APIs by using a command line flag.
const base::CommandLine* cmd_line = base::CommandLine::ForCurrentProcess();
if (cmd_line->HasSwitch(switches::kForceWaveAudio)) {
DVLOG(1) << "Forcing usage of Windows WaveXxx APIs";
return false;
}
However, PCMWaveOutAudioOutputStream is not being triggered in waveout_output_win.cc, hence the issue.
So far this has been the only way to redirect audio output in Chromium, which we use for spatializing audio in VR/AR virtual browsers (using CEF).
If you no longer plan to support kForceWaveAudio / "force-wave-audio", please remove it from the codebase. Is there a new way to intercept the audio output that we can use?
UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36
,
Nov 13
,
Nov 13
regomatic@ Thanks for the issue. Request you to provide a sample file/URL where this issue can be reproduced, which will help in further triaging. Thanks..
,
Nov 13
Hi Susan, Here is a sample URL where this issue is reproduced for me: https://www.youtube.com/watch?v=OzUrIBYWCDA I've been able to reproduce it with any URL that produces audio output. Thanks, -Rego
,
Nov 13
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 13
IIRC Wave support was removed last year. Or was that just for input? Oskar, Olga, do you remember?
,
Nov 13
Tommi was working on that AFAIR. The code to create it still there [1]. Some flag check also there [2]. But I don't quite see how they meet together. [1] https://cs.chromium.org/chromium/src/media/audio/win/audio_manager_win.cc?type=cs&q=PCMWaveOutAudioOutputStream&g=0&l=211 [2] https://cs.chromium.org/chromium/src/media/audio/win/core_audio_util_win.cc?type=cs&q=kForceWaveAudio&g=0&l=284
,
Nov 13
Probably flag isn't passed to audio service anymore?
,
Dec 6
Hi folks. If IIRC Wave support is indeed removed, is there another way to intercept the audio output?
,
Dec 18
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dtapuska@google.com
, Nov 12