New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 904503 link

Starred by 1 user
Status: Verified
Owner:
xiaoh...@chromium.org
Closed: Nov 13
Cc:
omrilio@chromium.org
trumbull@chromium.org
elijahtaylor@chromium.org
█ shihuis@chromium.org
█ djaklich@chromium.org
saintlou@google.com
josa...@google.com
puneetster@google.com
chrome-os-gcon-escalation@google.com
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

crash loop in Assistance manager

Project Member Reported by khmel@chromium.org, Nov 12 
System goes to crash loop and cannot not recover. Crash happens soon after login but may vary up to 10s.

https://crash.corp.google.com/browse?q=EXISTS+%28SELECT+1+FROM+UNNEST%28CrashedStackTrace.StackFrame%29+WHERE+FunctionName%3D%27chromeos%3A%3Aassistant%3A%3AAssistantManagerServiceImpl%3A%3ASendGetSettingsUiRequest%28std%3A%3A__1%3A%3Abasic_string%3Cchar%2C+std%3A%3A__1%3A%3Achar_traits%3Cchar%3E%2C+std%3A%3A__1%3A%3Aallocator%3Cchar%3E+%3E+const%26%2C+base%3A%3AOnceCallback%3Cvoid+%28std%3A%3A__1%3A%3Abasic_string%3Cchar%2C+std%3A%3A__1%3A%3Achar_traits%3Cchar%3E%2C+std%3A%3A__1%3A%3Aallocator%3Cchar%3E+%3E+const%26%29%3E%29%27%29&stbtiq=&reportid=&index=0#1


0x000058c49178d3ba	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/chromeos/services/assistant/assistant_manager_service_impl.cc:220 )	chromeos::assistant::AssistantManagerServiceImpl::SendGetSettingsUiRequest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::OnceCallback<void (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)>)
0x000058c49179714f	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/chromeos/services/assistant/assistant_settings_manager_impl.cc:27 )	chromeos::assistant::AssistantSettingsManagerImpl::GetSettings(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, base::OnceCallback<void (std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)>)
0x000058c490e54b9b	(chrome -./gen/chromeos/services/assistant/public/mojom/settings.mojom.cc:1116 )	chromeos::assistant::mojom::AssistantSettingsManagerStubDispatch::AcceptWithResponder(chromeos::assistant::mojom::AssistantSettingsManager*, mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >)
0x000058c491797345	(chrome -./gen/chromeos/services/assistant/public/mojom/settings.mojom.h:305 )	chromeos::assistant::mojom::AssistantSettingsManagerStub<mojo::RawPtrImplRefTraits<chromeos::assistant::mojom::AssistantSettingsManager> >::AcceptWithResponder(mojo::Message*, std::__1::unique_ptr<mojo::MessageReceiverWithStatus, std::__1::default_delete<mojo::MessageReceiverWithStatus> >)
0x000058c4929c4f86	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:398 )	mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept(mojo::Message*)
0x000058c48f7f29e4	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/mojo/public/cpp/bindings/lib/interface_endpoint_client.cc:306 )	mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*)
0x000058c48f7f21d7	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/mojo/public/cpp/bindings/lib/multiplex_router.cc:590 )	mojo::internal::MultiplexRouter::Accept(mojo::Message*)
0x000058c48f7f1d8c	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/mojo/public/cpp/bindings/lib/connector.cc:476 )	mojo::Connector::ReadAllAvailableMessages()
0x000058c48f7f36b3	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/base/callback.h:129 )	mojo::SimpleWatcher::OnHandleReady(int, unsigned int, mojo::HandleSignalsState const&)
0x000058c48f7e3687	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/base/callback.h:99 )	base::MessageLoop::DoWork()
0x000058c48f7ef5ee	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/base/message_loop/message_pump_libevent.cc:210 )	base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)
0x000058c492902d93	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/base/run_loop.cc:102 )	<name omitted>
0x000058c4924858df	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/chrome_browser_main.cc:1909 )	ChromeBrowserMainParts::MainMessageLoopRun(int*)
0x000058c4907a40eb	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/content/browser/browser_main_loop.cc:994 )	content::BrowserMainLoop::RunMainMessageLoopParts()
0x000058c4907a8701	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/content/browser/browser_main_runner_impl.cc:165 )	content::BrowserMainRunnerImpl::Run()
0x000058c49079c211	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/content/browser/browser_main.cc:47 )	content::BrowserMain(content::MainFunctionParams const&)
0x000058c492473225	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/content/app/content_main_runner_impl.cc:547 )	content::ContentMainRunnerImpl::Run(bool)
0x000058c49247b209	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/services/service_manager/embedder/main.cc:472 )	service_manager::Main(service_manager::MainParams const&)
0x000058c48f8db8ce	(chrome -./../../../../../../../home/chrome-bot/chrome_root/src/content/app/content_main.cc:19 )	ChromeMain
0x000079be437b4735	(libc-2.23.so -libc-start.c:289 )	__libc_start_main
0x000058c48f8c06c8	(chrome + 0x003216c8 )	_start

Comment 1 by khmel@chromium.org, Nov 12

Labels: OS-Chrome
Owner: xiaoh...@chromium.org
assistant_manager_internal_ is null in case of crash.

Comment 2 by khmel@chromium.org, Nov 12

Status: Assigned (was: Untriaged)

Comment 3 by xiaoh...@chromium.org, Nov 12 

This may have been fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1330751

Do you have a repro step that we can verify?

Comment 4 by khmel@chromium.org, Nov 12 

I got it on my machine by shut-downing initial OOBE (shelf menu->Shutdown) after accepting ARC ToS. Next attempt I tried login switched to crash loop. I checked crash stack from my machine with crash/ and found users' cases.
I did not track this problem explicitly.

Comment 5 by bhthompson@google.com, Nov 13

Labels: -Pri-1 Pri-0
Does this potentially impact Nocturne?

If so this is now a P0.

Comment 6 by khmel@chromium.org, Nov 13 

#5 - This was reproduced on nocturne.

Comment 7 by josa...@google.com, Nov 13

Cc: djaklich@chromium.org omrilio@chromium.org trumbull@chromium.org

Comment 9 by khmel@chromium.org, Nov 13 

#8 - I see several reports in M70.

Comment 10 by xiaoh...@chromium.org, Nov 13 

re #9, yes, but those are very old M70 build, <70.3538.22. The current is 70.3538.106. Whatever issue causing those 7 crashes are most likely different issues and fixed already.

Comment 11 by xiaoh...@chromium.org, Nov 13 

I am able to repro the issue by flashing to an older build R72-11235.0.0 and following steps in #4.  After pushing a locally build Chrome from TOT, the device is out of the crash loop. I am closing this bug and the fix is the CL mentioned in #3.

Comment 12 by xiaoh...@chromium.org, Nov 13

Status: Fixed (was: Assigned)

Comment 13 by khmel@chromium.org, Nov 13 

So we can wait while #3 reaches user and check for new crashes.

Comment 14 by trumb...@google.com, Nov 13

Labels: Hotlist-ConOps-CrOS

Comment 15 by abod...@chromium.org, Jan 7

Status: Verified (was: Fixed)
Verified on chrome OS 11316.66.0, 72.0.3626.49
►

Sign in to add a comment