New issue
Advanced search Search tips

Issue 904477 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Nov 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Re-disable move dtor in PatchList in perfetto

Project Member Reported by fdegans@chromium.org, Nov 12

Issue description

The move dtor for the PatchList was disabled in https://android-review.googlesource.com/c/platform/external/perfetto/+/822041 due to breaking the gtest roll.
gtest was modified to use std::tuple rather than its own implementation but the VC++ implementation of the C++ STL requires a move constructor for the usage in patch_list_unittest. Specifically, the calls to "ElementsAre" fail to compile on Windows.
 

Comment 1 Deleted

Comment 2 Deleted

Status: Archived (was: Assigned)
Thanks for filing. Sorry forgot to mention that we keep track of Perfetto bugs in b/.
Moved to b/119496181
 

Sign in to add a comment