New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 904469 link

Starred by 1 user
Status: Assigned
Owner:
liaoyuke@chromium.org
Cc:
█ robert...@chromium.org
liaoyuke@chromium.org
mmoroz@chromium.org
infe...@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Consolidate flat and compressed data format into one and use protobuf

Project Member Reported by liaoyuke@chromium.org, Nov 12 
1. Currently, for the sake of debugging and prototyping, two formats (flat and compressed) exist simultaneously in the code base, eventually, the flat one should be removed in favor of compressed one, and a debugging page should be developed in the service so that the compressed format can be properly decompressed and presented on a UI when something goes wrong and needs debugging.

2. Protobuf should instead be used to replace the json, because it's more tractable and format can be documented in the .proto file, which will make it easier to maintain and develop new features in the future.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/5d7896293dee4e983315fd3bd57979cb9eaf1b62

commit 5d7896293dee4e983315fd3bd57979cb9eaf1b62
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Fri Nov 30 05:39:28 2018

[code coverage] Consolidate two coverage format

This CL changes the recipe:
1. For per-cl coverage data, rebase the compressed format instead of
   the flat one.
2. Delete the flat format in favor of compressed format.

This CL is dependent on the server side change:
https://chromium-review.googlesource.com/c/infra/infra/+/1355699

Bug: 904469
Change-Id: I6a7648a65daf2dafed94c7800039e48e203db00a
Reviewed-on: https://chromium-review.googlesource.com/c/1351694
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/5d7896293dee4e983315fd3bd57979cb9eaf1b62/scripts/slave/README.recipes.md
[modify] https://crrev.com/5d7896293dee4e983315fd3bd57979cb9eaf1b62/scripts/slave/recipe_modules/clang_coverage/unittests/generate_coverage_metadata_test.py
[modify] https://crrev.com/5d7896293dee4e983315fd3bd57979cb9eaf1b62/scripts/slave/recipe_modules/clang_coverage/resources/generate_coverage_metadata.py
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4b60d640bb3ca2f70f47fec9d2e8605683014692

commit 4b60d640bb3ca2f70f47fec9d2e8605683014692
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Fri Nov 30 05:52:34 2018

[code coverage] Serve per-cl coverage data using the compressed format

In https://chromium-review.googlesource.com/c/chromium/tools/build/+/1351694,
the flat format is deleted in favor of the compressed format, and this
CL makes necessary change at the service side accordingly.

Bug: 904469
Change-Id: Ie0bf9969f951c5475c6b8ca188b9e0279071d973
Reviewed-on: https://chromium-review.googlesource.com/c/1355699
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19273}
[modify] https://crrev.com/4b60d640bb3ca2f70f47fec9d2e8605683014692/appengine/findit/handlers/code_coverage.py
►

Sign in to add a comment