Meowth crashes when tab is moved by touching |
||||
Issue descriptionChrome Version: 71.0.3578.8 dev 11151.4.0 OS: ChromeOS What steps will reproduce the problem? (1) Connect Meowth with external display and make external display as primary one (2) Open a new browser tab in internal display (3) Touch the tab to move it What is the expected result? Tab is able to be moved to external display. What happens instead? System crashes. Additional info: I found this bug when trying to reproduce issue 897976 (https://crbug.com/897976). Now it seems that when window is opened in internal display, it is not at the very left edge now. Not sure whether the two bugs have some connection.
,
Nov 13
Tried on Tot. Also crash.
,
Nov 13
xdai@ can you take a look? There are several crashes on the server that seems to be similar, example: https://crash.corp.google.com/browse?q=&stbtiq=ash::WindowSelector::RemoveWindowSelectorItem&reportid=d4395c98dc9e07fd&index=4#0 Please talk to andrewxu@ who can show you how to repro this crash.
,
Dec 18
Talked with Min. Assign to her. From andreawxu@: on tot (M73), no need to set the external display as the primary display, Chrome will always crash when moving a chrome window (tab dragging or app dragging) from internal display to external display using touch.
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/251a0089da078885a03dcbd62e66472cb6fbb2f7 commit 251a0089da078885a03dcbd62e66472cb6fbb2f7 Author: Min Chen <minch@google.com> Date: Thu Dec 20 17:38:19 2018 Fix crash happened if drag tab/app between displays. The crash in the issue is because WindowGrid::GetWindowSelectorItemContaining returns nullptr then cause crashed at WindowSelector::RemoveWindowSelectorItem. It is nullptr because the drop target and dragged window are in different displays. This cl fixes the crash only and will see whether we can do further work for it. Bug: 904466 Change-Id: I20a7ca5a0d294d23b28be13ab0c27a5fdfdc5c45 Reviewed-on: https://chromium-review.googlesource.com/c/1383535 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#618264} [modify] https://crrev.com/251a0089da078885a03dcbd62e66472cb6fbb2f7/ash/wm/overview/window_grid.cc
,
Dec 20
|
||||
►
Sign in to add a comment |
||||
Comment 1 by andrewxu@google.com
, Nov 13