Do not require any extra dependencies to run soundwave scripts |
||||
Issue descriptionCurrently soundwave scripts rely on some external dependencies (notably oauth2client.tools and pandas), which users are required to install before being able to use pinpoint_cli and soundwave itself. The first of those dependencies will no longer be needed after issue 903026 is fixed, relying instead on luci-auth (available from depot_tools) to authorize requests. For the second, after issue 878994 got fixed, we can now get pandas from vpython.
,
Nov 12
,
Nov 12
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/b81a9c76c982129c6ec624367bcb0c0dca4a49d3 commit b81a9c76c982129c6ec624367bcb0c0dca4a49d3 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Fri Nov 16 12:23:48 2018 [soundwave] Run soundwave scripts using vpython Use vpython to run pinpoint_cli, soundwave, and other scripts, this allows developers to run these scripts without having to install any extra dependencies. Also this allows to start running unit tests for soundwave project on bots. Bug: chromium:904441 Change-Id: If265e239bb8e46f52a9ee70a24202c58c2b251b1 Reviewed-on: https://chromium-review.googlesource.com/c/1331430 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ben Hayden <benjhayden@chromium.org> [modify] https://crrev.com/b81a9c76c982129c6ec624367bcb0c0dca4a49d3/catapult_build/build_steps.py [modify] https://crrev.com/b81a9c76c982129c6ec624367bcb0c0dca4a49d3/experimental/soundwave/bin/run_tests [modify] https://crrev.com/b81a9c76c982129c6ec624367bcb0c0dca4a49d3/experimental/soundwave/soundwave/tables/alerts_test.py [modify] https://crrev.com/b81a9c76c982129c6ec624367bcb0c0dca4a49d3/experimental/soundwave/pinpoint_cli/histograms_df_test.py [modify] https://crrev.com/b81a9c76c982129c6ec624367bcb0c0dca4a49d3/experimental/soundwave/bin/pinpoint_cli [modify] https://crrev.com/b81a9c76c982129c6ec624367bcb0c0dca4a49d3/experimental/soundwave/soundwave/worker_pool.py [modify] https://crrev.com/b81a9c76c982129c6ec624367bcb0c0dca4a49d3/experimental/soundwave/soundwave/worker_pool_test.py [modify] https://crrev.com/b81a9c76c982129c6ec624367bcb0c0dca4a49d3/experimental/soundwave/bin/soundwave [modify] https://crrev.com/b81a9c76c982129c6ec624367bcb0c0dca4a49d3/tracing/tracing/value/histogram.py [modify] https://crrev.com/b81a9c76c982129c6ec624367bcb0c0dca4a49d3/.vpython [modify] https://crrev.com/b81a9c76c982129c6ec624367bcb0c0dca4a49d3/experimental/soundwave/bin/export_csv [modify] https://crrev.com/b81a9c76c982129c6ec624367bcb0c0dca4a49d3/tracing/tracing/value/histogram_unittest.py
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95012fbd344c3c333fc38f6338293b873150e77c commit 95012fbd344c3c333fc38f6338293b873150e77c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Nov 16 14:02:11 2018 Roll src/third_party/catapult b053faa13970..b81a9c76c982 (2 commits) https://chromium.googlesource.com/catapult.git/+log/b053faa13970..b81a9c76c982 git log b053faa13970..b81a9c76c982 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 perezju@chromium.org [soundwave] Run soundwave scripts using vpython 2018-11-16 perezju@chromium.org [soundwave] Migrate isolate_service to luci-auth Created with: gclient setdep -r src/third_party/catapult@b81a9c76c982 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:904441 , chromium:903026 TBR=sullivan@chromium.org Change-Id: I348fa92c0279d3a9eb309b221a3359b7f9bd991e Reviewed-on: https://chromium-review.googlesource.com/c/1340146 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608757} [modify] https://crrev.com/95012fbd344c3c333fc38f6338293b873150e77c/DEPS
,
Nov 16
Done too. Scripts now runnable without having to install anything extra. |
||||
►
Sign in to add a comment |
||||
Comment 1 by perezju@chromium.org
, Nov 12