New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 904423 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Pinpoint doesn't work on non-Telemetry tests

Project Member Reported by perezju@chromium.org, Nov 12

Issue description

It looks like pinpoint does not currently support running base_perftests

E.g. test try job incorrectly picks "performance_test_suite" target:
https://pinpoint-dot-chromeperf.appspot.com/job/156af613e40000

Is there any hope this would work by crafting and directly sending a request with the right target (and any other args)? Or is there more work to be done on pinpoint backend for this to work?

FYI this is how the test is scheduled to run on perf waterfall:
https://cs.chromium.org/chromium/src/testing/buildbot/chromium.perf.json?rcl=d190843847cdb5cff0dc258d15cf3fa5d763c19f&l=812
 
Cc: skyos...@chromium.org
Thank Juan! FWIW I'm also seeing error 500s with my attempt to run base_perftests: https://pinpoint-dot-chromeperf.appspot.com/job/134647cfe40000
Cc: benjhayden@chromium.org
Components: -Speed>Bisection Speed>TBM2
Bisects for GTest (C++) perf tests are supported on the backend. Try jobs are not, since those tests output GraphJson instead of HistogramSets, and there's no results2 support for GraphJson.

Comment 2: I'll upload a CL for the 500 errors.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/e69406dde9dd13ff550468f741cb625aa9eb061f

commit e69406dde9dd13ff550468f741cb625aa9eb061f
Author: Dave Tu <dtu@chromium.org>
Date: Thu Nov 15 18:51:00 2018

[pinpoint] Add metric property to Quest. Don't imply GraphJson Quest based on arguments.

* Add a default metric name property to Quest that just returns "Failure rate".
* Don't let Quest.FromDict() return None. If the request arguments
  don't match the Quest, it should always throw a TypeError.
  If the API user doesn't want to use that Quest, they should pass in
  the "quests" argument to specify a list of Quests.

Bug: chromium:904423
Change-Id: Iaade285510e18a26a9f1bfd7df6f35a58665c12e
Reviewed-on: https://chromium-review.googlesource.com/c/1336447
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Dave Tu <dtu@chromium.org>

[modify] https://crrev.com/e69406dde9dd13ff550468f741cb625aa9eb061f/dashboard/dashboard/pinpoint/handlers/new.py
[modify] https://crrev.com/e69406dde9dd13ff550468f741cb625aa9eb061f/dashboard/dashboard/pinpoint/models/quest/read_value_test.py
[modify] https://crrev.com/e69406dde9dd13ff550468f741cb625aa9eb061f/dashboard/dashboard/pinpoint/models/quest/read_value.py
[modify] https://crrev.com/e69406dde9dd13ff550468f741cb625aa9eb061f/dashboard/dashboard/pinpoint/models/quest/quest.py

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff39524881aa025e87148b4526c53a589aab1164

commit ff39524881aa025e87148b4526c53a589aab1164
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Nov 15 21:57:30 2018

Roll src/third_party/catapult eaddc34b5d48..e69406dde9dd (2 commits)

https://chromium.googlesource.com/catapult.git/+log/eaddc34b5d48..e69406dde9dd


git log eaddc34b5d48..e69406dde9dd --date=short --no-merges --format='%ad %ae %s'
2018-11-15 dtu@chromium.org [pinpoint] Add metric property to Quest. Don't imply GraphJson Quest based on arguments.
2018-11-15 cbruni@chromium.org [telemetry] Log page action names in the ActionRunner


Created with:
  gclient setdep -r src/third_party/catapult@e69406dde9dd

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:904423
TBR=sullivan@chromium.org

Change-Id: Id1e9b66e752cfe0e165bc3547cfac13afc6a734d
Reviewed-on: https://chromium-review.googlesource.com/c/1338149
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608531}
[modify] https://crrev.com/ff39524881aa025e87148b4526c53a589aab1164/DEPS

Comment 6 by simonhatch@chromium.org, Jan 18 (4 days ago)

Cc: simonhatch@chromium.org eyaich@chromium.org st...@chromium.org crouleau@chromium.org perezju@chromium.org dtu@chromium.org gab@chromium.org
 Issue 908505  has been merged into this issue.

Comment 7 by simonhatch@chromium.org, Jan 18 (4 days ago)

Components: Speed>Bisection
Owner: simonhatch@chromium.org
Status: Started (was: Available)
Picking this up, think we can get try jobs running without too many changes. If the frontend can send the right isolate target, and the backend can do some conversion of the graphjson to histograms, the results can display. I did a quickie conversion in read_value as a test here: https://pinpoint-dot-chromeperf.appspot.com/job/16c1729a540000

I converted the graphjson values to histograms, and attached a couple diagnostics to differentiate before/after runs. Not sure if much more is needed but we can iterate as necessary.
Project Member

Comment 8 by bugdroid1@chromium.org, Today (16 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/42feef6ebcf840287133138ed5b906effd040dc1

commit 42feef6ebcf840287133138ed5b906effd040dc1
Author: Simon <simonhatch@chromium.org>
Date: Tue Jan 22 15:20:05 2019

Pinpoint - Support non-telemetry perf tests

The backend already supports running non-telemetry tests, but we just
need to make sure ones kicked off get the right isolate target and
that the graphjson reader is updated accept None arguments (like the
histogram reader).

There's a graphjson -> histogram converter supplied in tracing/value so
we just use that directly in results2.

Bug: chromium:904423
Change-Id: I721104fa0247f5c7df9c9bce5cf7ce270b933d57
Reviewed-on: https://chromium-review.googlesource.com/c/1425221
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/42feef6ebcf840287133138ed5b906effd040dc1/dashboard/dashboard/pinpoint/elements/jobs-page/new-job-fab.html
[modify] https://crrev.com/42feef6ebcf840287133138ed5b906effd040dc1/dashboard/dashboard/pinpoint/models/quest/read_value_test.py
[modify] https://crrev.com/42feef6ebcf840287133138ed5b906effd040dc1/dashboard/dashboard/pinpoint/models/quest/read_value.py
[modify] https://crrev.com/42feef6ebcf840287133138ed5b906effd040dc1/dashboard/dashboard/pinpoint/models/results2.py

Project Member

Comment 9 by bugdroid1@chromium.org, Today (14 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2185f4c6e32b7e7eda8d2f0b1cf770c6d873d9ab

commit 2185f4c6e32b7e7eda8d2f0b1cf770c6d873d9ab
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Jan 22 17:05:53 2019

Roll src/third_party/catapult d4e9197559c4..42feef6ebcf8 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/d4e9197559c4..42feef6ebcf8


git log d4e9197559c4..42feef6ebcf8 --date=short --no-merges --format='%ad %ae %s'
2019-01-22 simonhatch@chromium.org Pinpoint - Support non-telemetry perf tests


Created with:
  gclient setdep -r src/third_party/catapult@42feef6ebcf8

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:904423
TBR=sullivan@chromium.org

Change-Id: I3414d82d068aee8824a0624689e143ee2a789ed4
Reviewed-on: https://chromium-review.googlesource.com/c/1426719
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#624802}
[modify] https://crrev.com/2185f4c6e32b7e7eda8d2f0b1cf770c6d873d9ab/DEPS

Comment 10 by crouleau@chromium.org, Today (8 hours ago)

Summary: Pinpoint doesn't work on non-Telemetry tests (was: Support running base_perftests in pinpoint)

Sign in to add a comment