Create IdentityTestEnvironment{Profile, BrowserState}Adaptor::Create*ForIdentityTestEnvironment() variants that take in a Builder |
||
Issue descriptionThis is tonikitoo's suggestion, and it's a very good one. This will give us maximum flexibility on configuring the Profile. Once we have this, we should convert usages of the variant that takes in TestingFactories to usages of this and then collapse all the variants into one that takes an optional Builder argument.
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec966cb51c2df2dbed25b4b5de82db7e03cc517b commit ec966cb51c2df2dbed25b4b5de82db7e03cc517b Author: Antonio Gomes <tonikitoo@igalia.com> Date: Tue Nov 13 13:21:23 2018 [s13n] Add IdentityTestEnvironment{Profile,BrowserState}Adaptor::CreateXXX variant that takes a Builder In follow ups, users of the existing APIs can be converted. BUG= 904419 Change-Id: I6691fb32ec79d5de5c97c09bb886bf3d6bc2c047 Reviewed-on: https://chromium-review.googlesource.com/c/1332749 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#607572} [modify] https://crrev.com/ec966cb51c2df2dbed25b4b5de82db7e03cc517b/chrome/browser/signin/identity_test_environment_profile_adaptor.cc [modify] https://crrev.com/ec966cb51c2df2dbed25b4b5de82db7e03cc517b/chrome/browser/signin/identity_test_environment_profile_adaptor.h [modify] https://crrev.com/ec966cb51c2df2dbed25b4b5de82db7e03cc517b/ios/chrome/browser/signin/identity_test_environment_chrome_browser_state_adaptor.cc [modify] https://crrev.com/ec966cb51c2df2dbed25b4b5de82db7e03cc517b/ios/chrome/browser/signin/identity_test_environment_chrome_browser_state_adaptor.h
,
Nov 13
|
||
►
Sign in to add a comment |
||
Comment 1 by toniki...@chromium.org
, Nov 12Owner: toniki...@chromium.org
Status: Started (was: Available)