New issue
Advanced search Search tips

Issue 904412 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 15
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Convert signin_ui_util away from ProfileOAuth2TokenService

Project Member Reported by blundell@chromium.org, Nov 12

Issue description

Should be straightforward.
 
Blockedon: 889899
This one requires a mapping for SigninManager::IsAllowedUsername(), blocked on 889899
Blockedon: -889899
> This one requires a mapping for SigninManager::IsAllowedUsername(), blocked on 889899

Oops! Too fast: That would be to move away from SigninManager, not from PO2TS. @blundell can you clarify whether leaving the dependency on SigninManager would be ok here?
Sure, let's do PO2TS for now :).
Owner: ma...@igalia.com
Status: Started (was: Available)
Thanks for clarifying. Assigning now...
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/945828b60437c73f8f9160831331e2adaef6b2ef

commit 945828b60437c73f8f9160831331e2adaef6b2ef
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Thu Nov 15 17:52:05 2018

Convert signin_ui_util away from ProfileOAuth2TokenService

Replace usage of PO2TS APIs with calls to IdentityManager's methods.

Bug:  904412 
Change-Id: I0543f8e4c78a5b19915933082f9f9074dcb4d7d8
Reviewed-on: https://chromium-review.googlesource.com/c/1338082
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#608424}
[modify] https://crrev.com/945828b60437c73f8f9160831331e2adaef6b2ef/chrome/browser/signin/signin_ui_util.cc

Status: Fixed (was: Started)

Sign in to add a comment