New issue
Advanced search Search tips

Issue 904407 link

Starred by 2 users
Status: Fixed
Owner:
toniki...@chromium.org
Closed: Nov 14
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Convert profile_downloader_unittest.cc away from using ProfileOAuth2TokenService

Project Member Reported by blundell@chromium.org, Nov 12 
The usage of OAuth2TokenService::DiagnosticsObserver can be replaced by usage of IdentityManager::DiagnosticsObserver. Other than that nuance, the conversion should be straightforward.

Comment 1 by toniki...@chromium.org, Nov 14

Owner: toniki...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b33214021c662a278d50d34fc88098786322ae2c

commit b33214021c662a278d50d34fc88098786322ae2c
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Nov 14 15:13:36 2018

[s13n] Convert profile_downloader_unittest.cc away from using ProfileOAuth2TokenService

BUG= 904407 

Change-Id: Ibfc219bb273a7ff8ee1d8693ca2f25994a038f5b
Reviewed-on: https://chromium-review.googlesource.com/c/1335907
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#607981}
[modify] https://crrev.com/b33214021c662a278d50d34fc88098786322ae2c/chrome/browser/profiles/profile_downloader_unittest.cc

Comment 3 by toniki...@chromium.org, Nov 14

Status: Fixed (was: Started)
►

Sign in to add a comment