New issue
Advanced search Search tips

Issue 904406 link

Starred by 2 users
Status: Fixed
Owner:
lowell@chromium.org
Closed: Nov 22
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Eliminate stale profile_oauth2_token_service includes from profiles_state.cc

Project Member Reported by blundell@chromium.org, Nov 12 
These includes look unused.

Comment 1 by blundell@chromium.org, Nov 16

Owner: blundell@chromium.org
Status: Assigned (was: Available)
Reserving this bug :).

Comment 2 by blundell@chromium.org, Nov 21

Owner: lowell@chromium.org

Comment 3 by blundell@chromium.org, Nov 21

Summary: Eliminate stale profile_oauth2_token_service includes from profiles_state.cc (was: Eliminate stale PO2TS includes from profiles_state.cc)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/937314d2ec9e9f7f8ed0784914c41d4815c5a2f2

commit 937314d2ec9e9f7f8ed0784914c41d4815c5a2f2
Author: Lowell Manners <lowell@chromium.org>
Date: Thu Nov 22 13:05:36 2018

Delete unused includes from profiles_state.cc

This CL deletes unused includes of ProfileOAuth2TokenService from
profiles_state.cc. This aids in the conversion of the codebase from
ProfileOAuth2TokenService to IdentityManager.

Bug:  904406 
Change-Id: Ibb8f9ca0c7d27b51857ce5932600972db109682b
Reviewed-on: https://chromium-review.googlesource.com/c/1346452
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610393}
[modify] https://crrev.com/937314d2ec9e9f7f8ed0784914c41d4815c5a2f2/chrome/browser/profiles/profiles_state.cc

Comment 5 by lowell@chromium.org, Nov 22

Status: Fixed (was: Assigned)
►

Sign in to add a comment