New issue
Advanced search Search tips

Issue 904403 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

ui_test_utils::SendGlobalKeyEventsAndWait doesn't work on macOS 10.14

Project Member Reported by ellyjo...@chromium.org, Nov 12

Issue description

This is a test-only API that uses CGEventPost(), which requires a user confirmation on 10.14, so any uses of it will hang.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa553244ad41e64339ae6d8deadb686ef83f6011

commit aa553244ad41e64339ae6d8deadb686ef83f6011
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Mon Nov 12 21:01:44 2018

mac: disable GlobalCommandsApiTest GlobalCommand on 10.14

As of 10.14, the API that SendGlobalKeyEventsAndWait() uses to post global
events causes a user prompt to appear, which is an obvious non-starter in test
scenarios, so disable that test for now, and add a DCHECK in
SendGlobalKeyEventsAndWait() to ensure that it is not called on 10.14.

Bug:  892177 ,904403
Change-Id: Ida0429d7e9914942f354690ecb657803240756ae
Reviewed-on: https://chromium-review.googlesource.com/c/1331135
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607325}
[modify] https://crrev.com/aa553244ad41e64339ae6d8deadb686ef83f6011/chrome/browser/extensions/extension_commands_global_registry_apitest.cc
[modify] https://crrev.com/aa553244ad41e64339ae6d8deadb686ef83f6011/chrome/test/base/interactive_test_utils_mac.mm

Sign in to add a comment