New issue
Advanced search Search tips

Issue 904401 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

diagnosticsd: Wire up EC-daemon-processor message passing pipe

Project Member Reported by lamzin@google.com, Nov 12

Issue description

Implement gRPC interface between EC chip, diagnostics daemon and diagnostics processor.
 
Description: Show this description
Components: OS>Systems
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/41ee42a45023b65503fa5ec78d848272033288d9

commit 41ee42a45023b65503fa5ec78d848272033288d9
Author: Oleh Lamzin <lamzin@google.com>
Date: Thu Nov 15 16:11:45 2018

diagnostics: declare EC gRPC interface for daemon

Declare EC gRPC interface for diagnostics daemon.

BUG= chromium:904401 
TEST=Tested with unittests.

Change-Id: Id2194d822e2467900aa32563699aacd08726c89b
Reviewed-on: https://chromium-review.googlesource.com/1331487
Commit-Ready: Oleh Lamzin <lamzin@google.com>
Tested-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>

[modify] https://crrev.com/41ee42a45023b65503fa5ec78d848272033288d9/diagnostics/grpc/diagnosticsd.proto

Labels: Sarien
Labels: Type-Feature
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a0769d28c2a984666c284d65b96b19344cf42e67

commit a0769d28c2a984666c284d65b96b19344cf42e67
Author: Oleh Lamzin <lamzin@google.com>
Date: Tue Nov 27 08:34:10 2018

diagnostics: declare GetEcProperty gRPC method

Add new gRPC method to diagnosticsd daemon. GetEcProperty returns EC
property using EC sysfs driver.

BUG= chromium:904401 
TEST=The diagnostics package successfully builds.

Change-Id: Id97e40dffd8d1972e6dc9fd16eb7052f4bfb0571
Reviewed-on: https://chromium-review.googlesource.com/1341792
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>

[modify] https://crrev.com/a0769d28c2a984666c284d65b96b19344cf42e67/diagnostics/grpc/diagnosticsd.proto

Labels: -Pri-2 Pri-1
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/8a632e4c85983d22fc1672ee1f47bafea2e023c6

commit 8a632e4c85983d22fc1672ee1f47bafea2e023c6
Author: Oleh Lamzin <lamzin@google.com>
Date: Sat Dec 01 15:50:25 2018

diagnostics: implement GetEcProperty gRPC method

Implement GetEcProperty gRPC method for diagnostics daemon.

BUG= chromium:904401 
TEST=Tested with unittests.

Change-Id: Ic9f3c12f90514790d0125cbdf8a86afceb824a44
Reviewed-on: https://chromium-review.googlesource.com/1343320
Commit-Ready: Oleh Lamzin <lamzin@google.com>
Tested-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>

[modify] https://crrev.com/8a632e4c85983d22fc1672ee1f47bafea2e023c6/diagnostics/diagnosticsd/diagnosticsd_core.cc
[modify] https://crrev.com/8a632e4c85983d22fc1672ee1f47bafea2e023c6/diagnostics/diagnosticsd/fake_diagnostics_processor.cc
[modify] https://crrev.com/8a632e4c85983d22fc1672ee1f47bafea2e023c6/diagnostics/diagnosticsd/diagnosticsd_grpc_service.cc
[modify] https://crrev.com/8a632e4c85983d22fc1672ee1f47bafea2e023c6/diagnostics/diagnosticsd/diagnosticsd_grpc_service.h
[add] https://crrev.com/8a632e4c85983d22fc1672ee1f47bafea2e023c6/diagnostics/diagnosticsd/file_test_utils.h
[modify] https://crrev.com/8a632e4c85983d22fc1672ee1f47bafea2e023c6/diagnostics/diagnostics.gyp
[modify] https://crrev.com/8a632e4c85983d22fc1672ee1f47bafea2e023c6/diagnostics/diagnosticsd/diagnosticsd_grpc_service_test.cc
[add] https://crrev.com/8a632e4c85983d22fc1672ee1f47bafea2e023c6/diagnostics/diagnosticsd/file_test_utils.cc
[modify] https://crrev.com/8a632e4c85983d22fc1672ee1f47bafea2e023c6/diagnostics/diagnosticsd/fake_diagnostics_processor.h
[modify] https://crrev.com/8a632e4c85983d22fc1672ee1f47bafea2e023c6/diagnostics/diagnosticsd/diagnosticsd_core_test.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cde3f3746c8f112abb885cd36919902f86fdcc70

commit cde3f3746c8f112abb885cd36919902f86fdcc70
Author: Oleh Lamzin <lamzin@google.com>
Date: Sat Dec 01 15:50:26 2018

diagnostics: implement RunEcCommand gRPC method

Implement RunEcCommand gRPC method for diagnostics daemon.

BUG= chromium:904401 
TEST=Tested with unittests.

Change-Id: I49d087f5fc014178e02afbf1d544fcc341945c2d
Reviewed-on: https://chromium-review.googlesource.com/1353979
Commit-Ready: Oleh Lamzin <lamzin@google.com>
Tested-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>

[modify] https://crrev.com/cde3f3746c8f112abb885cd36919902f86fdcc70/diagnostics/diagnosticsd/diagnosticsd_core.cc
[modify] https://crrev.com/cde3f3746c8f112abb885cd36919902f86fdcc70/diagnostics/diagnosticsd/fake_diagnostics_processor.cc
[modify] https://crrev.com/cde3f3746c8f112abb885cd36919902f86fdcc70/diagnostics/diagnosticsd/diagnosticsd_grpc_service.cc
[modify] https://crrev.com/cde3f3746c8f112abb885cd36919902f86fdcc70/diagnostics/diagnosticsd/diagnosticsd_grpc_service.h
[modify] https://crrev.com/cde3f3746c8f112abb885cd36919902f86fdcc70/diagnostics/diagnosticsd/diagnosticsd_grpc_service_test.cc
[modify] https://crrev.com/cde3f3746c8f112abb885cd36919902f86fdcc70/diagnostics/grpc/diagnosticsd.proto
[modify] https://crrev.com/cde3f3746c8f112abb885cd36919902f86fdcc70/diagnostics/diagnosticsd/fake_diagnostics_processor.h
[modify] https://crrev.com/cde3f3746c8f112abb885cd36919902f86fdcc70/diagnostics/diagnosticsd/diagnosticsd_core_test.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5c93cc687522843e32768f2ea0b748b68ef74055

commit 5c93cc687522843e32768f2ea0b748b68ef74055
Author: Oleh Lamzin <lamzin@google.com>
Date: Thu Dec 20 18:03:52 2018

diagnostics: add EC properties

Add EC properties:
- PID_FN_LOCK
- PID_NIC
- PID_EXT_USB_PORT_EN
- PID_WIRELESS_SW_WLAN
- PID_AUTO_BOOT_ON_TRINITY_DOCK_ATTACH
- PID_ICH_AZALIA_EN
- PID_SIGN_OF_LIFE_KBBL

And move all EC constants to separate .h/.cc files.

BUG= chromium:904401 
TEST=Tested with unittests.

Change-Id: I9510ff22acf9756cde900083d1f405129c2520ac
Reviewed-on: https://chromium-review.googlesource.com/1380151
Commit-Ready: Oleh Lamzin <lamzin@google.com>
Tested-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[add] https://crrev.com/5c93cc687522843e32768f2ea0b748b68ef74055/diagnostics/diagnosticsd/ec_constants_test.cc
[modify] https://crrev.com/5c93cc687522843e32768f2ea0b748b68ef74055/diagnostics/diagnosticsd/diagnosticsd_grpc_service.cc
[modify] https://crrev.com/5c93cc687522843e32768f2ea0b748b68ef74055/diagnostics/diagnosticsd/diagnosticsd_grpc_service.h
[modify] https://crrev.com/5c93cc687522843e32768f2ea0b748b68ef74055/diagnostics/diagnostics.gyp
[add] https://crrev.com/5c93cc687522843e32768f2ea0b748b68ef74055/diagnostics/diagnosticsd/ec_constants.h
[modify] https://crrev.com/5c93cc687522843e32768f2ea0b748b68ef74055/diagnostics/diagnosticsd/diagnosticsd_grpc_service_test.cc
[modify] https://crrev.com/5c93cc687522843e32768f2ea0b748b68ef74055/diagnostics/grpc/diagnosticsd.proto
[add] https://crrev.com/5c93cc687522843e32768f2ea0b748b68ef74055/diagnostics/diagnosticsd/ec_constants.cc
[modify] https://crrev.com/5c93cc687522843e32768f2ea0b748b68ef74055/diagnostics/diagnosticsd/diagnosticsd_core_test.cc

Status: Fixed (was: Started)

Sign in to add a comment