New issue
Advanced search Search tips

Issue 904385 link

Starred by 2 users
Status: Assigned
Owner:
rdevlin....@chromium.org
Cc:
a...@chromium.org
rdevlin....@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : [Mac] Able to open app's context menu on background page even when 'Remove' dialog box is active.

Reported by avsha...@etouch.net, Nov 12 
Chrome Version : 72.0.3608.0 (Official Build) 13a876533812d5e196bca2b1c60634dc14a79700-refs/branch-heads/3608@{#1} 64 bit
OS : Mac(10.13.6, 10.13.1, 10.14.2)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://apps page, right click on any app and select 'Remove from Chrome..' option.('Remove' dialog appears)
2. Keep 'Remove' dialog open and right click on any other app available on the page.
3. Observe.

Actual Result : Able to open app's context menu on background page even when 'Remove' dialog box is active. (though user can not click on options in context menu )

Expected Result : Chrome should not allow to open app's context menu on background page when 'Remove' dialog box is active.

This is a regression issue broken in M-70 and below is the bisect information:
Good Build : 70.0.3503.0 (Revision : 578160)
Bad Build : 70.0.3504.0 (Revision : 578510)

Change Log URL:
https://chromium.googlesource.com/chromium/src/+log/bcb7db78edc13f57577f0a9562c98918bdcc10ae..67d21d10815fe6d87d1785a65a50fbc386e6605b

Suspecting : https://chromium.googlesource.com/chromium/src/+/67d21d10815fe6d87d1785a65a50fbc386e6605b

ellyjones@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Issue is reproducible in Stable #70.0.3538.102, Beta #71.0.3578.44 and Dev #72.0.3602.2
2. Unable to reproduce issue in Windows (7,8,10) and Linux(14.04 LTS) OS.

Thank you..!
Expected_Result.mov
7.4 MB View Download
Actual_Result.mov
6.0 MB View Download

Comment 1 by ellyjo...@chromium.org, Nov 12

Labels: -Pri-1 -Target-70 -M-70 -Target-71 M-72 Pri-2
Owner: a...@chromium.org
Mac triage: over to avi@ for webcontents focus/modality issues :) definitely not Pri-1 though.

Comment 2 by a...@chromium.org, Nov 13 

What kind of dialog is that? It should be blocking the page for input, yes?

Comment 3 by a...@chromium.org, Nov 13 

This is ExtensionUninstallDialogDelegateView. It doesn't seem to be using the standard web-modal dialog mechanism.

Comment 5 by a...@chromium.org, Nov 13

Cc: rdevlin....@chromium.org

Comment 6 by a...@chromium.org, Nov 14

Cc: a...@chromium.org
Owner: rdevlin....@chromium.org
But it can't because it's not clear what WebContents is the active one.

Can we find the browser window and block/unblock the WebContents in front? What happens when the tab is switched? Which it can't, but I'm crashing.

Devlin, can you take this?

Comment 7 by a...@chromium.org, Nov 14 

BTW, this seems to be very intertwined with MacViews, so the Mac team may need to be involved. I don't think window modal dialogs work right in MacViews yet.

Comment 8 by a...@chromium.org, Nov 14 

Also, forget comment 4. As this is a window-modal dialog, it should be capturing input. That's what should be happening, not using the web-modal stuff.
►

Sign in to add a comment