chrome://sync-internals displays wrong times for USS datatypes |
|||
Issue descriptionThe "Sync Node Browser" tab within chrome://sync-internals doesn't show proper timestamps for USS datatypes. Steps to repro (on a syncing device): 1. Open chrome://sync-internals, tab "Sync Node Browser". 2. Click on a USS datatype, e.g. DeviceInfo. 3. Click on any sync entity. Expected: Timestamps like "MTIME" should display a proper time (note that prior to M71 there was another bug which makes this be "MODIFICATION_TIME" instead, fixed by mamir@ in https://chromium-review.googlesource.com/1196370. Actual: It displays the unix epoch: "Thursday, January 1, 1970 at 1:00:00 AM". Directory datatypes are unaffected, e.g. PASSWORDS. The solution would probably involve a fix in ClientTagBasedModelTypeProcessor::MergeDataWithMetadataForDebugging(), where these timestamps (and possibly other fields) must be copied from sync metadata, independently of the bridge's EntityData.
,
Nov 19
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98256bd5638a078f46b835bac36bba05c8804c30 commit 98256bd5638a078f46b835bac36bba05c8804c30 Author: Jan Krcal <jkrcal@chromium.org> Date: Mon Nov 19 17:02:06 2018 [USS] Show mtime and other fields in sync-internals Node Browser This CL copies over EntityMetadata fields into EntityData for USS types in ClientTagBasedModelTypeProcessor::MergeDataWithMetadataForDebugging() so that the right values appear in chrome://sync-internals. Bug: 904376 Change-Id: Ifd8ef57d32677770ac61f2d3fceaed5f939ba048 Reviewed-on: https://chromium-review.googlesource.com/c/1341993 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609334} [modify] https://crrev.com/98256bd5638a078f46b835bac36bba05c8804c30/components/sync/model_impl/client_tag_based_model_type_processor.cc
,
Nov 19
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jkrcal@chromium.org
, Nov 19Status: Started (was: Available)