New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 904373 link

Starred by 1 user
Status: Fixed
Owner:
█ rsgingerrs@chromium.org
Last visit 20 days ago
Closed: Dec 5
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Favicon icon is misaligned in Password Manager in the settings.

Reported by dchau...@etouch.net, Nov 12 
Chrome Version: 72.0.3608.0 (Official Build) Revision	13a876533812d5e196bca2b1c60634dc14a79700-refs/branch-heads/3608@{#1} (32/64-bit)
OS: Windows (7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2) and Linux(14.04 LTS).

Precondition: At-least 1 password entry must be saved under 'Saved Password' section on chrome://settings/passwords page.  

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings/appearance and change Font size to 'Very large'.
2. Now navigate to chrome://settings/passwords and observe the favicon icon under 'Saved Password' section.

Actual: Favicon icon is misaligned.
Expected: Favicon icon should aligned properly.

This is a regression issue, broken in M-72 series, below is manual regression range:

Good build: 72.0.3593.0 (Revision: 603286)
Bad build: 72.0.3594.0 (Revision: 603354)

You are probably looking for a change made after 603286 (known good), but no later than 603289 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/b027b38a0726d515cc725be85247fa353166ee46..5549403d26cfe6240f72e7790842cd24d3c9dfc1

Suspecting: https://chromium.googlesource.com/chromium/src/+/f7157ed9182e341ec40630d47154f11966232f6b

@rsgingerrs: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE:
1. Provided suspect through 'Chromium bisect' script because unable to perform bisect using 'per-revision' bisect script.
2. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect." error.
3. This issue also reproducible on Dev #72.0.3602.2

Kindly review the attached screen-cast for reference.

Thank you.
Favicon_Actual.png
192 KB View Download
Actual behavior.mp4
692 KB View Download
Expected behavior.mp4
441 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76ae1466e5cbad1d1a5bc36958c4141b08cd06ff

commit 76ae1466e5cbad1d1a5bc36958c4141b08cd06ff
Author: Yue Cen <rsgingerrs@chromium.org>
Date: Wed Nov 14 21:22:00 2018

Password manager: Align the favicon properly when font size changes

Bug:  904373 
Change-Id: Ie1cbc2df7b63aca2ddc5b0686e666d16dd2b5f2d
Reviewed-on: https://chromium-review.googlesource.com/c/1332407
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608124}
[modify] https://crrev.com/76ae1466e5cbad1d1a5bc36958c4141b08cd06ff/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html

Comment 2 by dchau...@etouch.net, Nov 15

Labels: TE-Verified-M72 TE-Verified-72.0.3611.0
Update:
Rechecked this issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2) and Linux(14.04) machines using latest Canary #72.0.3611.0 and issue is fixed. Hence adding TE-Verified labels.

please refer the attached screen-cast for reference.

Thank you.
Fixed behavior.mp4
544 KB View Download

Comment 3 by dpa...@chromium.org, Dec 5

Status: Fixed (was: Assigned)
I believe this is fixed?
►

Sign in to add a comment