New issue
Advanced search Search tips

Issue 904372 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , iOS , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

tab_background_text color not respected

Reported by bagsbu...@gmail.com, Nov 12

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36

Steps to reproduce the problem:
1. Install Misty Forest theme.

What is the expected behavior?
Inactive tab text color should be green.

What went wrong?
Inactive tab text color is white.

WebStore page: https://chrome.google.com/webstore/detail/misty-forest-1080p/kdlkeopgmhejabhhpgjmmchbfblmklek

Did this work before? Yes Before chrome redesign

Chrome version: 72.0.3608.1  Channel: canary
OS Version: 10.0
Flash Version: 

Mysty Forest in 72.0.3608.1: https://i.imgur.com/YgGMoUQ.png
Mysty Forest in 66.0.3359.170: https://i.imgur.com/OmYJa6K.png
 
Labels: Needs-Bisect Needs-Triage-M72
Possible related issues:  issue 871026  and  issue 877853 . (some context behind the redesign in this area)
Cc: swarnasree.mukkala@chromium.org
Labels: Triaged-ET Needs-Feedback
Able to reproduce the issue on reported chrome version #70.0.3538.77, latest stable 70.0.3538.102 and latest chrome #72.0.3608.0 using Windows 10.When tried bisecting the issue, on chrome version #69.0.3480.0 found a different behavior that the text color of inactive tab strip is black. 
Attached screenshot for reference.

@reporter: Could you please confirm if this can be taken as bad behavior and also requesting you to confirm if the issue is similar to issue id: 871026 so that it would be really helpful for further triaging of the issue.
Thanks.! 
904372.PNG
218 KB View Download
@3 I'am the author of this theme and I consider this bad behavior because I'am not able to set desired text color even though it's readable. I tried to set text color to different shades of green and even different colors but only white or black colors worked.

The problem in the 871026 issue seems to be different since tabs text color in theme "Colors" is set to black ("tab_background_text": [ 0, 0, 0 ]) and it's black as it intended be.
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 14

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision RegressedIn-69 Target-70 Target-71 Target-72 FoundIn-72 M-72 FoundIn-71 FoundIn-70 OS-iOS OS-Linux OS-Mac Pri-1
Owner: kylixrd@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported chrome version #72.0.3608.1 and latest chrome #72.0.3608.4 using Windows 10 , Ubuntu 17.10 and Mac 10.13.6 by following steps as per comment#0. The following is the bisect information.

Bisect information:
==============
Good Build: 69.0.3472.0
Bad Build:69.0.3473.0

Change Log:"https://chromium.googlesource.com/chromium/src/+log/f47d80e576f0c8f2da769ce0e26cff2e423ad103..8a4187003e401bcb6a541427fe72fc425c5a9f1b"
Reviewed On:"https://chromium-review.googlesource.com/1102821".

@Allen Bauer: Please help us in reassigning the issue if this is not related to your change.
Thanks.!
It's got worse since the last time I posted. Some of my themes now broken as of Chrome 71. Here is one of them: https://chrome.google.com/webstore/detail/pure-white-theme-with-blu/jpffhnbjhklaeegcbokpepanmekpfnla
The tab_text is black even though it's set to white. I tried to make theme_toolbar fully blue but the text stayed black. Please see attached files. 

Similar issues also happens with bookmark_text. Generally, if theme is of lighter colors it's impossible to change text from black to white (or to any other color), even if white is more readable.
71.png
46.8 KB View Download

Sign in to add a comment