Change to predetermined resource ids broke lots of Windows bots. |
|||||
Issue descriptionThe bots are failing with [1328:856:1109/182200.972:FATAL:data_pack.cc(444)] Check failed: !handle->HasResource(resource_id). Duplicate resource 301 with scale 1 Backtrace: base::debug::StackTrace::StackTrace [0x71040650+32] base::debug::StackTrace::StackTrace [0x7103FE0D+13] logging::LogMessage::~LogMessage [0x71058AD0+96] ui::DataPack::CheckForDuplicateResources [0x71852303+263] ui::ResourceBundle::AddDataPack [0x7114A173+35] ui::ResourceBundle::AddDataPackFromPathInternal [0x7114A0C2+214] ui::ResourceBundle::AddDataPackFromPath [0x71149FE8+16] LoadLocalState [0x7100DDA8+380] ChromeMainDelegate::PostEarlyInitialization [0x700E212F+115] content::ContentMainRunnerImpl::Run [0x70FDDD62+778] content::ContentServiceManagerMainDelegate::RunEmbedderProcess [0x70FDD38F+19] service_manager::Main [0x70FE7A98+1384] content::ContentMain [0x70FDD583+51] ChromeMain [0x700E119C+288] MainDllLoader::Launch [0x000E55A8+554] wWinMain [0x000E146D+1133] __scrt_common_main_seh [0x001ECCBA+248] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283) BaseThreadInitThunk [0x75D28674+36] RtlGetAppContainerNamedObjectPath [0x774D5D87+311] RtlGetAppContainerNamedObjectPath [0x774D5D57+263] (No symbol) [0x00000000] This is the only commit in this first failing build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Exp%20Release%20%28NVIDIA%29/19877 It is already a revert of a build that caused compile failures so it can't be reverted. There doesn't seem to have been conflicts between the commit and the revert so it seems some state is wrong on the bots? Actually after digging more it looks like the rules to generate the resource id headers don't depend on the predetermined id files even though they use them as command-line arguments. I'll make a patch for this.
,
Nov 12
And Win10 Tests x64 is failing the same way. Upgrading to P0
,
Nov 12
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90369e8b18445677b7c1bd3a436271de1c59e556 commit 90369e8b18445677b7c1bd3a436271de1c59e556 Author: Corentin Wallez <cwallez@chromium.org> Date: Mon Nov 12 11:46:53 2018 grit_rules.gni: Fix missing dependency on predetermined IDs The missing dependency would cause the resource_ids to not be regenerated when the predetermined ids file were changed, causing various compilation failures on bots. BUG= 904366 TBR=thestig@chromium.org Change-Id: I310af635916e66ad7d35437d7116b2a3f7fae2a9 Reviewed-on: https://chromium-review.googlesource.com/c/1329793 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#607193} [modify] https://crrev.com/90369e8b18445677b7c1bd3a436271de1c59e556/tools/grit/grit_rule.gni
,
Nov 12
,
Nov 13
Thank you Corentin and great work fixing up the build rapidly! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by cwallez@chromium.org
, Nov 12