Issue metadata
Sign in to add a comment
|
external/wpt/webusb/idlharness.https.any.worker.html is flaky |
||||||||||||||||||||||||
Issue descriptionFlaky test: external/wpt/webusb/idlharness.https.any.worker.html Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests%20%28dbg%29/6367 Test output log: https://chromium-swarm.appspot.com/task?id=411ee8616c5c3710 Culprit (73.3% confidence): r606876 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyzwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKYAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cyAoZGJnKS82MzY3L3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvWlhoMFpYSnVZV3d2ZDNCMEwzZGxZblZ6WWk5cFpHeG9ZWEp1WlhOekxtaDBkSEJ6TG1GdWVTNTNiM0pyWlhJdWFIUnRiQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20external/wpt/webusb/idlharness.https.any.worker.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyzwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKYAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cyAoZGJnKS82MzY3L3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvWlhoMFpYSnVZV3d2ZDNCMEwzZGxZblZ6WWk5cFpHeG9ZWEp1WlhOekxtaDBkSEJ6TG1GdWVTNTNiM0pyWlhJdWFIUnRiQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87db0e76078d63cad178c06262438ba5ae9351b4 commit 87db0e76078d63cad178c06262438ba5ae9351b4 Author: Patrik Höglund <phoglund@chromium.org> Date: Mon Nov 12 13:01:55 2018 Revert "Add more information to |error| of -didFailFavigationWithSSLError:." This reverts commit af760c9155256a267d8f3a284aa52492ae57b3c9. Reason for revert: Appears to cause flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/6367. The crash stack trace mentions SSL. If this CL is innocent, then please just reland. Original change's description: > Add more information to |error| of -didFailFavigationWithSSLError:. > > Add error.localizedDescription and error.userInfo[CWVCertStatusKey]. > > Bug: 898037 > Change-Id: I3e552330378992574d7c08f96f343aba6a7b4d29 > Reviewed-on: https://chromium-review.googlesource.com/c/1325578 > Reviewed-by: Carlos IL <carlosil@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607127} TBR=eugenebut@chromium.org,ichikawa@chromium.org,carlosil@chromium.org Change-Id: Ieffa8431079996675b1d53f058e4059fa74b8d09 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898037 , 904345 Reviewed-on: https://chromium-review.googlesource.com/c/1329972 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#607205} [modify] https://crrev.com/87db0e76078d63cad178c06262438ba5ae9351b4/ios/web_view/BUILD.gn [modify] https://crrev.com/87db0e76078d63cad178c06262438ba5ae9351b4/ios/web_view/internal/DEPS [delete] https://crrev.com/2e38d313a49bc8c28b8ce38f004776dbf4357b99/ios/web_view/internal/cwv_navigation_delegate.mm [modify] https://crrev.com/87db0e76078d63cad178c06262438ba5ae9351b4/ios/web_view/internal/cwv_ssl_status.mm [modify] https://crrev.com/87db0e76078d63cad178c06262438ba5ae9351b4/ios/web_view/internal/cwv_ssl_status_internal.h [modify] https://crrev.com/87db0e76078d63cad178c06262438ba5ae9351b4/ios/web_view/internal/web_view_web_client.mm [modify] https://crrev.com/87db0e76078d63cad178c06262438ba5ae9351b4/ios/web_view/public/cwv_navigation_delegate.h
,
Nov 12
phoglund: The CL you reverted is iOS-only. Probably not the cause of a Mac test flake. :-P findit pointed to r606876, and this link here shows a stack trace in the ConnectJobs, so that's probably it. https://chromium-swarm.appspot.com/task?id=411ee8616c5c3710&refresh=10&show_raw=1
,
Nov 12
> a stack trace in the ConnectJobs Sorry, meant to say in the socket pools. But somewhere in that general vicinity anyway.
,
Nov 12
The relevant crash (Since pulling it from the logs is a bit of a pain). It looks to me like this may well be blink doing something weird (decreasing the priority of an IGNORE_LIMITS request): 19:06:55.202 2492 worker/5 external/wpt/webusb/idlharness.https.any.worker.html crashed, (stderr lines): 19:06:55.202 2492 [3221:20483:1111/190655.079339:FATAL:client_socket_pool_base.cc(1543)] Check failed: request->respect_limits() == ClientSocketPool::RespectLimits::ENABLED (0 vs. 1) 19:06:55.202 2492 0 libbase.dylib 0x00000001118f3663 base::debug::StackTrace::StackTrace(unsigned long) + 83 19:06:55.202 2492 1 libbase.dylib 0x00000001118f371d base::debug::StackTrace::StackTrace(unsigned long) + 29 19:06:55.202 2492 2 libbase.dylib 0x00000001115e37aa base::debug::StackTrace::StackTrace() + 26 19:06:55.202 2492 3 libbase.dylib 0x000000011162b0fe logging::LogMessage::~LogMessage() + 142 19:06:55.202 2492 4 libbase.dylib 0x0000000111629ef5 logging::LogMessage::~LogMessage() + 21 19:06:55.202 2492 5 libnet.dylib 0x00000001328a9164 net::internal::ClientSocketPoolBaseHelper::Group::SetPriority(net::ClientSocketHandle*, net::RequestPriority) + 404 19:06:55.202 2492 6 libnet.dylib 0x00000001328a8edf net::internal::ClientSocketPoolBaseHelper::SetPriority(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, net::ClientSocketHandle*, net::RequestPriority) + 351 19:06:55.202 2492 7 libnet.dylib 0x000000013290009a net::ClientSocketPoolBase<net::TransportSocketParams>::SetPriority(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, net::ClientSocketHandle*, net::RequestPriority) + 58 19:06:55.202 2492 8 libnet.dylib 0x000000013290005a net::TransportClientSocketPool::SetPriority(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, net::ClientSocketHandle*, net::RequestPriority) + 58 19:06:55.202 2492 9 libnet.dylib 0x0000000132396838 net::ClientSocketHandle::SetPriority(net::RequestPriority) + 120 19:06:55.203 2492 10 libnet.dylib 0x00000001328ea182 net::SSLConnectJob::ChangePriorityInternal(net::RequestPriority) + 82 19:06:55.203 2492 11 libnet.dylib 0x00000001328a36cc net::ConnectJob::ChangePriority(net::RequestPriority) + 44 19:06:55.203 2492 12 libnet.dylib 0x00000001328a4309 net::internal::ClientSocketPoolBaseHelper::Request::AssignJob(net::ConnectJob*) + 393 19:06:55.203 2492 13 libnet.dylib 0x00000001328b0d44 net::internal::ClientSocketPoolBaseHelper::Group::TryToAssignJobToRequest(net::PriorityQueue<std::__1::unique_ptr<net::internal::ClientSocketPoolBaseHelper::Request, std::__1::default_delete<net::internal::ClientSocketPoolBaseHelper::Request> > >::Pointer) + 292 19:06:55.203 2492 14 libnet.dylib 0x00000001328adb74 net::internal::ClientSocketPoolBaseHelper::Group::RemoveJob(net::ConnectJob*) + 788 19:06:55.203 2492 15 libnet.dylib 0x00000001328aa08e net::internal::ClientSocketPoolBaseHelper::RemoveConnectJob(net::ConnectJob*, net::internal::ClientSocketPoolBaseHelper::Group*) + 366 19:06:55.203 2492 16 libnet.dylib 0x00000001328acb99 net::internal::ClientSocketPoolBaseHelper::OnConnectJobComplete(int, net::ConnectJob*) + 761 19:06:55.203 2492 17 libnet.dylib 0x00000001328a3c7a net::ConnectJob::NotifyDelegateOfCompletion(int) + 298 19:06:55.203 2492 18 libnet.dylib 0x00000001328e77db net::SSLConnectJob::OnIOComplete(int) + 59 19:06:55.203 2492 19 libnet.dylib 0x00000001328ec734 void base::internal::FunctorTraits<void (net::SSLConnectJob::*)(int), void>::Invoke<void (net::SSLConnectJob::*)(int), net::SSLConnectJob*, int>(void (net::SSLConnectJob::*)(int), net::SSLConnectJob*&&, int&&) + 148 19:06:55.203 2492 20 libnet.dylib 0x00000001328ec626 void base::internal::InvokeHelper<false, void>::MakeItSo<void (net::SSLConnectJob::* const&)(int), net::SSLConnectJob*, int>(void (net::SSLConnectJob::* const&&&)(int), net::SSLConnectJob*&&, int&&) + 102 19:06:55.203 2492 21 libnet.dylib 0x00000001328ec595 void base::internal::Invoker<base::internal::BindState<void (net::SSLConnectJob::*)(int), base::internal::UnretainedWrapper<net::SSLConnectJob> >, void (int)>::RunImpl<void (net::SSLConnectJob::* const&)(int), std::__1::tuple<base::internal::UnretainedWrapper<net::SSLConnectJob> > const&, 0ul>(void (net::SSLConnectJob::* const&&&)(int), std::__1::tuple<base::internal::UnretainedWrapper<net::SSLConnectJob> > const&&&, std::__1::integer_sequence<unsigned long, 0ul>, int&&) + 101 19:06:55.203 2492 22 libnet.dylib 0x00000001328ec479 base::internal::Invoker<base::internal::BindState<void (net::SSLConnectJob::*)(int), base::internal::UnretainedWrapper<net::SSLConnectJob> >, void (int)>::Run(base::internal::BindStateBase*, int) + 89 19:06:55.203 2492 23 libnet.dylib 0x0000000132397bef base::OnceCallback<void (int)>::Run(int) && + 111 19:06:55.203 2492 24 libnet.dylib 0x00000001323a6a4a net::SSLClientSocketImpl::DoConnectCallback(int) + 106 19:06:55.203 2492 25 libnet.dylib 0x00000001323a4e08 net::SSLClientSocketImpl::OnHandshakeIOComplete(int) + 120 19:06:55.203 2492 26 libnet.dylib 0x00000001323a342c net::SSLClientSocketImpl::RetryAllOperations() + 92 19:06:55.203 2492 27 libnet.dylib 0x00000001323a33c5 net::SSLClientSocketImpl::OnReadReady() + 21 19:06:55.203 2492 28 libnet.dylib 0x000000013239a1b9 net::SocketBIOAdapter::OnSocketReadIfReadyComplete(int) + 409 19:06:55.203 2492 29 libnet.dylib 0x000000013239c166 void base::internal::FunctorTraits<void (net::SocketBIOAdapter::*)(int), void>::Invoke<void (net::SocketBIOAdapter::*)(int), base::WeakPtr<net::SocketBIOAdapter> const&, int>(void (net::SocketBIOAdapter::*)(int), base::WeakPtr<net::SocketBIOAdapter> const&&&, int&&) + 150 19:06:55.203 2492 30 libnet.dylib 0x000000013239c04f void base::internal::InvokeHelper<true, void>::MakeItSo<void (net::SocketBIOAdapter::* const&)(int), base::WeakPtr<net::SocketBIOAdapter> const&, int>(void (net::SocketBIOAdapter::* const&&&)(int), base::WeakPtr<net::SocketBIOAdapter> const&&&, int&&) + 127 19:06:55.203 2492 31 libnet.dylib 0x000000013239bfc7 void base::internal::Invoker<base::internal::BindState<void (net::SocketBIOAdapter::*)(int), base::WeakPtr<net::SocketBIOAdapter> >, void (int)>::RunImpl<void (net::SocketBIOAdapter::* const&)(int), std::__1::tuple<base::WeakPtr<net::SocketBIOAdapter> > const&, 0ul>(void (net::SocketBIOAdapter::* const&&&)(int), std::__1::tuple<base::WeakPtr<net::SocketBIOAdapter> > const&&&, std::__1::integer_sequence<unsigned long, 0ul>, int&&) + 87 19:06:55.203 2492 32 libnet.dylib 0x000000013239be89 base::internal::Invoker<base::internal::BindState<void (net::SocketBIOAdapter::*)(int), base::WeakPtr<net::SocketBIOAdapter> >, void (int)>::Run(base::internal::BindStateBase*, int) + 89 19:06:55.203 2492 33 libnet.dylib 0x0000000132397bef base::OnceCallback<void (int)>::Run(int) && + 111 19:06:55.203 2492 34 libnet.dylib 0x00000001328f88b4 net::TCPClientSocket::DidCompleteReadWrite(base::OnceCallback<void (int)>, int) + 68 19:06:55.203 2492 35 libnet.dylib 0x00000001328f71d8 net::TCPClientSocket::DidCompleteRead(base::OnceCallback<void (int)>, int) + 104 19:06:55.203 2492 36 libnet.dylib 0x00000001328f986f void base::internal::FunctorTraits<void (net::TCPClientSocket::*)(base::OnceCallback<void (int)>, int), void>::Invoke<void (net::TCPClientSocket::*)(base::OnceCallback<void (int)>, int), net::TCPClientSocket*, base::OnceCallback<void (int)>, int>(void (net::TCPClientSocket::*)(base::OnceCallback<void (int)>, int), net::TCPClientSocket*&&, base::OnceCallback<void (int)>&&, int&&) + 191 19:06:55.203 2492 37 libnet.dylib 0x00000001328f971b void base::internal::InvokeHelper<false, void>::MakeItSo<void (net::TCPClientSocket::*)(base::OnceCallback<void (int)>, int), net::TCPClientSocket*, base::OnceCallback<void (int)>, int>(void (net::TCPClientSocket::*&&)(base::OnceCallback<void (int)>, int), net::TCPClientSocket*&&, base::OnceCallback<void (int)>&&, int&&) + 123 19:06:55.203 2492 38 libnet.dylib 0x00000001328f9656 void base::internal::Invoker<base::internal::BindState<void (net::TCPClientSocket::*)(base::OnceCallback<void (int)>, int), base::internal::UnretainedWrapper<net::TCPClientSocket>, base::OnceCallback<void (int)> >, void (int)>::RunImpl<void (net::TCPClientSocket::*)(base::OnceCallback<void (int)>, int), std::__1::tuple<base::internal::UnretainedWrapper<net::TCPClientSocket>, base::OnceCallback<void (int)> >, 0ul, 1ul>(void (net::TCPClientSocket::*&&)(base::OnceCallback<void (int)>, int), std::__1::tuple<base::internal::UnretainedWrapper<net::TCPClientSocket>, base::OnceCallback<void (int)> >&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>, int&&) + 134 19:06:55.204 2492 39 libnet.dylib 0x00000001328f9503 base::internal::Invoker<base::internal::BindState<void (net::TCPClientSocket::*)(base::OnceCallback<void (int)>, int), base::internal::UnretainedWrapper<net::TCPClientSocket>, base::OnceCallback<void (int)> >, void (int)>::RunOnce(base::internal::BindStateBase*, int) + 99 19:06:55.204 2492 40 libnet.dylib 0x0000000132397bef base::OnceCallback<void (int)>::Run(int) && + 111 19:06:55.204 2492 41 libnet.dylib 0x0000000132cb3985 net::TCPSocketPosix::ReadIfReadyCompleted(base::OnceCallback<void (int)>, int) + 421 19:06:55.204 2492 42 libnet.dylib 0x0000000132cb6fdf void base::internal::FunctorTraits<void (net::TCPSocketPosix::*)(base::OnceCallback<void (int)>, int), void>::Invoke<void (net::TCPSocketPosix::*)(base::OnceCallback<void (int)>, int), net::TCPSocketPosix*, base::OnceCallback<void (int)>, int>(void (net::TCPSocketPosix::*)(base::OnceCallback<void (int)>, int), net::TCPSocketPosix*&&, base::OnceCallback<void (int)>&&, int&&) + 191 19:06:55.204 2492 43 libnet.dylib 0x0000000132cb6ebb void base::internal::InvokeHelper<false, void>::MakeItSo<void (net::TCPSocketPosix::*)(base::OnceCallback<void (int)>, int), net::TCPSocketPosix*, base::OnceCallback<void (int)>, int>(void (net::TCPSocketPosix::*&&)(base::OnceCallback<void (int)>, int), net::TCPSocketPosix*&&, base::OnceCallback<void (int)>&&, int&&) + 123 19:06:55.204 2492 44 libnet.dylib 0x0000000132cb6df6 void base::internal::Invoker<base::internal::BindState<void (net::TCPSocketPosix::*)(base::OnceCallback<void (int)>, int), base::internal::UnretainedWrapper<net::TCPSocketPosix>, base::OnceCallback<void (int)> >, void (int)>::RunImpl<void (net::TCPSocketPosix::*)(base::OnceCallback<void (int)>, int), std::__1::tuple<base::internal::UnretainedWrapper<net::TCPSocketPosix>, base::OnceCallback<void (int)> >, 0ul, 1ul>(void (net::TCPSocketPosix::*&&)(base::OnceCallback<void (int)>, int), std::__1::tuple<base::internal::UnretainedWrapper<net::TCPSocketPosix>, base::OnceCallback<void (int)> >&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>, int&&) + 134 19:06:55.204 2492 45 libnet.dylib 0x0000000132cb6cb3 base::internal::Invoker<base::internal::BindState<void (net::TCPSocketPosix::*)(base::OnceCallback<void (int)>, int), base::internal::UnretainedWrapper<net::TCPSocketPosix>, base::OnceCallback<void (int)> >, void (int)>::RunOnce(base::internal::BindStateBase*, int) + 99 19:06:55.204 2492 46 libnet.dylib 0x0000000132397bef base::OnceCallback<void (int)>::Run(int) && + 111 19:06:55.204 2492 47 libnet.dylib 0x0000000132cafe62 net::SocketPosix::ReadCompleted() + 386 19:06:55.204 2492 48 libnet.dylib 0x0000000132cafa0a net::SocketPosix::OnFileCanReadWithoutBlocking(int) + 506 19:06:55.204 2492 49 libbase.dylib 0x000000011193e01e base::MessagePumpLibevent::FdWatchController::OnFileCanReadWithoutBlocking(int, base::MessagePumpLibevent*) + 62 19:06:55.204 2492 50 libbase.dylib 0x000000011193f4b1 base::MessagePumpLibevent::OnLibeventNotification(int, short, void*) + 881 19:06:55.204 2492 51 libbase.dylib 0x0000000111942e6d event_process_active + 365 19:06:55.204 2492 52 libbase.dylib 0x00000001119423d4 event_base_loop + 468 19:06:55.204 2492 53 libbase.dylib 0x000000011193f5fd base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) + 189 19:06:55.204 2492 54 libbase.dylib 0x000000011166f878 base::MessageLoopImpl::Run(bool) + 504 19:06:55.204 2492 55 libbase.dylib 0x000000011171d1ed base::RunLoop::Run() + 525 19:06:55.204 2492 56 libbase.dylib 0x0000000111842e99 base::Thread::Run(base::RunLoop*) + 393 19:06:55.204 2492 57 libcontent.dylib 0x0000000116eff9d5 content::BrowserProcessSubThread::IOThreadRun(base::RunLoop*) + 53 19:06:55.204 2492 58 libcontent.dylib 0x0000000116eff8ab content::BrowserProcessSubThread::Run(base::RunLoop*) + 331 19:06:55.204 2492 59 libbase.dylib 0x00000001118436d7 base::Thread::ThreadMain() + 1303 19:06:55.204 2492 60 libbase.dylib 0x0000000111919ef0 base::(anonymous namespace)::ThreadFunc(void*) + 192 19:06:55.204 2492 61 libsystem_pthread.dylib 0x00007fff50325661 _pthread_body + 340 19:06:55.204 2492 62 libsystem_pthread.dylib 0x00007fff5032550d _pthread_body + 0 19:06:55.204 2492 63 libsystem_pthread.dylib 0x00007fff50324bf9 thread_start + 13 19:06:55.204 2492 19:06:55.214 2447 [4403/6408] external/wpt/webusb/idlharness.https.any.worker.html failed unexpectedly (Content Shell crashed [pid=3221])
,
Nov 12
Oh, it's not blink, it is indeed a new bug. What's most likely happening is we're associating a ConnectJob with the IGNORE_LIMITS flag set with a Request that does not have that flag set (After the Request with the IGNORE_LIMITS flag set was itself cancelled). I suggest disabling the DCHECK while we resolve the issue offline.
,
Nov 12
Talked to chlily, and we're going to revert.
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc8c60c35aac283f098567ec35045b821b9590c7 commit dc8c60c35aac283f098567ec35045b821b9590c7 Author: Lily Chen <chlily@chromium.org> Date: Mon Nov 12 19:20:01 2018 Revert "Add reprioritization to SSLConnectJobs" This reverts commit 8a9302e29c7625fd7cdc65f374fc7f00550c21aa. Reason for revert: Causing flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html Original change's description: > Add reprioritization to SSLConnectJobs > > This change allows the priority of an SSLConnectJob to be changed. If > the reprioritization occurs while the job is establishing its underlying > connection, the priority change is also passed down to the lower-level > socket pool. > > Bug: 166689 > Change-Id: I87d1e536846443901cc628423f4615c3ffa7542a > Reviewed-on: https://chromium-review.googlesource.com/c/1327423 > Commit-Queue: Lily Chen <chlily@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606876} TBR=mmenke@chromium.org,chlily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 166689, 904345 Change-Id: I6458798e11d210258f2a26330548f1ca33eb6c90 Reviewed-on: https://chromium-review.googlesource.com/c/1331139 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#607301} [modify] https://crrev.com/dc8c60c35aac283f098567ec35045b821b9590c7/net/socket/socket_test_util.cc [modify] https://crrev.com/dc8c60c35aac283f098567ec35045b821b9590c7/net/socket/socket_test_util.h [modify] https://crrev.com/dc8c60c35aac283f098567ec35045b821b9590c7/net/socket/ssl_client_socket_pool.cc [modify] https://crrev.com/dc8c60c35aac283f098567ec35045b821b9590c7/net/socket/ssl_client_socket_pool.h [modify] https://crrev.com/dc8c60c35aac283f098567ec35045b821b9590c7/net/socket/ssl_client_socket_pool_unittest.cc
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e7d961a7165c8e42a90cd752adb9c9be423d9b0 commit 8e7d961a7165c8e42a90cd752adb9c9be423d9b0 Author: Hiroshi Ichikawa <ichikawa@chromium.org> Date: Mon Nov 12 23:45:36 2018 Reland "Add more information to |error| of -didFailFavigationWithSSLError:." This reverts commit 87db0e76078d63cad178c06262438ba5ae9351b4. Reason for revert: The original CL was reverted as a culprit of a flaky crash. But it turned out to be innocent per discussion in https://crrev.com/c/1329972. Original change's description: > Revert "Add more information to |error| of -didFailFavigationWithSSLError:." > > This reverts commit af760c9155256a267d8f3a284aa52492ae57b3c9. > > Reason for revert: Appears to cause flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/6367. The crash stack trace mentions SSL. If this CL is innocent, then please just reland. > > Original change's description: > > Add more information to |error| of -didFailFavigationWithSSLError:. > > > > Add error.localizedDescription and error.userInfo[CWVCertStatusKey]. > > > > Bug: 898037 > > Change-Id: I3e552330378992574d7c08f96f343aba6a7b4d29 > > Reviewed-on: https://chromium-review.googlesource.com/c/1325578 > > Reviewed-by: Carlos IL <carlosil@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#607127} > > TBR=eugenebut@chromium.org,ichikawa@chromium.org,carlosil@chromium.org > > Change-Id: Ieffa8431079996675b1d53f058e4059fa74b8d09 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 898037 , 904345 > Reviewed-on: https://chromium-review.googlesource.com/c/1329972 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607205} TBR=phoglund@chromium.org,eugenebut@chromium.org,ichikawa@chromium.org,carlosil@chromium.org Change-Id: I4ac81df8f2c1386acc0683c0a03e5d022a826b95 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898037 , 904345 Reviewed-on: https://chromium-review.googlesource.com/c/1332967 Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#607372} [modify] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/BUILD.gn [modify] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/internal/DEPS [add] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/internal/cwv_navigation_delegate.mm [modify] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/internal/cwv_ssl_status.mm [modify] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/internal/cwv_ssl_status_internal.h [modify] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/internal/web_view_web_client.mm [modify] https://crrev.com/8e7d961a7165c8e42a90cd752adb9c9be423d9b0/ios/web_view/public/cwv_navigation_delegate.h
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fce715c8550c41ccd29617649eae7ff024ee3185 commit fce715c8550c41ccd29617649eae7ff024ee3185 Author: Lily Chen <chlily@chromium.org> Date: Fri Nov 16 21:19:30 2018 Reland "Add reprioritization to SSLConnectJobs" This reverts commit dc8c60c35aac283f098567ec35045b821b9590c7. Reason for revert: Bug causing crashes was fixed in https://crrev.com/c/1333135 Original change's description: > Revert "Add reprioritization to SSLConnectJobs" > > This reverts commit 8a9302e29c7625fd7cdc65f374fc7f00550c21aa. > > Reason for revert: Causing flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html > > Original change's description: > > Add reprioritization to SSLConnectJobs > > > > This change allows the priority of an SSLConnectJob to be changed. If > > the reprioritization occurs while the job is establishing its underlying > > connection, the priority change is also passed down to the lower-level > > socket pool. > > > > Bug: 166689 > > Change-Id: I87d1e536846443901cc628423f4615c3ffa7542a > > Reviewed-on: https://chromium-review.googlesource.com/c/1327423 > > Commit-Queue: Lily Chen <chlily@chromium.org> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#606876} > > TBR=mmenke@chromium.org,chlily@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 166689, 904345 > Change-Id: I6458798e11d210258f2a26330548f1ca33eb6c90 > Reviewed-on: https://chromium-review.googlesource.com/c/1331139 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Lily Chen <chlily@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607301} TBR=mmenke@chromium.org,chlily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 166689, 904345 Change-Id: I54fe803331be6fe3df534c0f6042bf0fb0057cbb Reviewed-on: https://chromium-review.googlesource.com/c/1340824 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#608950} [modify] https://crrev.com/fce715c8550c41ccd29617649eae7ff024ee3185/net/socket/socket_test_util.cc [modify] https://crrev.com/fce715c8550c41ccd29617649eae7ff024ee3185/net/socket/socket_test_util.h [modify] https://crrev.com/fce715c8550c41ccd29617649eae7ff024ee3185/net/socket/ssl_client_socket_pool.cc [modify] https://crrev.com/fce715c8550c41ccd29617649eae7ff024ee3185/net/socket/ssl_client_socket_pool.h [modify] https://crrev.com/fce715c8550c41ccd29617649eae7ff024ee3185/net/socket/ssl_client_socket_pool_unittest.cc
,
Nov 16
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by phoglund@google.com
, Nov 12Labels: -Sheriff-Chromium
Owner: ichikawa@google.com
Status: Assigned (was: Untriaged)