New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 904343 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-11-28
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:[NTP]User is able to edit custom link titles beyond defined character limit

Reported by vineetha...@etouch.net, Nov 12

Issue description

Chrome Version: 72.0.3608.0 (Official Build) Revision 13a876533812d5e196bca2b1c60634dc14a79700-refs/branch-heads/3608@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10),  Mac (10.13.1, 10.13.6, 10.14.2) and Linux(14.04)

Pre-condition: Enable "Enable using the Google local NTP" and "New Tab Page Custom Links" flags under chrome://flags.

What steps will reproduce the problem?
1. Launch chrome, open NTP, open 'Add shortcut' overlay.
2. Add a new shortcut and add long text(more than 150 characters) in the name field.
3. Now try editing the added shortcut name and observe.

Actual Result  : Continuation dots are seen after 150 characters and when user tries to edit shortcut name, he is allowed to add more characters.

Expected Result: 1. Either user should not be allowed to add more characters to the shortcut name field as it has crossed the maximum permissible limit. 
                 2. Or if above is an intended behavior then Continuation dots should get expanded when user tries to add more characters to shortcut name and the characters should get appended at the end.

This is a regression issue broken in ‘M-71’ and below is the 'per-revision' bisect information:
Good Build : 71.0.3543.0 (Revision : 588719)
Bad Build  : 71.0.3544.0 (Revision : 589076)

You are probably looking for a change made after 589067 (known good), but no later than 589068 (first known bad).

CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.  

https://chromium.googlesource.com/chromium/src/+log/68a35fc7ca051d1b12187cb405d688c864d9d4b7..577427e5227fca46ec3d39f1116f3bca7b467fdb

Suspect: https://chromium.googlesource.com/chromium/src/+/577427e5227fca46ec3d39f1116f3bca7b467fdb

@kristipark: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the attached screen-cast.

Thank you

 
ActualVideo.mp4
686 KB View Download
ExpectedVideo.mp4
643 KB View Download
Labels: zine-triaged
Labels: -Pri-1 Pri-2
Status: Started (was: Assigned)
Labels: -Target-71 KR-NTP-MD2-Polish O-Polish-Birthday-Features
NextAction: 2018-11-28
Labels: small
Status: WontFix (was: Started)
Marking this as WontFix. Truncation with ellipsis already occurs after clicking Done, and adding an ellipsis in the text field is overly complex compared to the occurrence of this issue.
The NextAction date has arrived: 2018-11-28

Sign in to add a comment