Issue metadata
Sign in to add a comment
|
Regression:'Speech' option is not seen in context menu of Web GL experiments.
Reported by
shruti.j...@etouch.net,
Nov 12
|
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3608.0 Revision 13a876533812d5e196bca2b1c60634dc14a79700-refs/branch-heads/3608@{#1}(64 bit) OS: Mac(10.13.1 , 10.13.6 , 10.14.1) Test URL:https://alteredqualia.com/three/examples/webgl_pasta.html Steps to reproduce: 1. Launch chrome and navigate to above URL. 2. Right click on Web GL experiments and observe. Actual Result : 'Speech' option is not seen in context menu. Expected Result : 'Speech' option should be seen in context menu. This is a regression issue broken in M-68 and below is the bisect information: Good Build :68.0.3424.0 Bad Build :68.0.3425.0 You are probably looking for a change made after 557026 (known good), but no later than 557027 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/b5df39cb30f2366b8abfbeb53a58f2785217340a..608546eea6e57e17c08b2989265fa9c8a81be01d Suspecting:https://chromium.googlesource.com/chromium/src/+/608546eea6e57e17c08b2989265fa9c8a81be01d @Mathieu Perreault :Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly refer the attached screencast from drive link: https://drive.google.com/open?id=1FFW29SpV3sGIxmxi-Jdw_UwLvwFrYIBa Note : 1.Issue is not seen on OS: Windows(7,8,8.1,10) and Linux(14.04 LTS) Thank You!
,
Nov 12
,
Nov 27
Hi, yes that seems like a thing I could have broken! I'll have a look soon.
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/911c660e261e874f0b98f46e3966ff86a93713b5 commit 911c660e261e874f0b98f46e3966ff86a93713b5 Author: Mathieu Perreault <mathp@chromium.org> Date: Mon Dec 10 15:04:33 2018 [Mac Context Menu] Add missing items to mac context menu (renderer) Due to bad refactoring in a previous change [1], some items like the Speech functionality was not being added properly. This is now fixed by allowing text_services_context_menu_.AppendToContextMenu(&menu_model_) to be called. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1045990/10/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm See Bug for repro steps. Bug: 904339 Change-Id: I1794cd24c4b9b7f68ef892aa851a01affbb5cbdb Reviewed-on: https://chromium-review.googlesource.com/c/1366865 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#615117} [modify] https://crrev.com/911c660e261e874f0b98f46e3966ff86a93713b5/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm
,
Dec 10
,
Dec 10
Let's verify this in canary first, before reviewing merge.
,
Dec 11
Update : Retested above issue on Mac(10.13.1 , 10.13.6 , 10.14.2) OS using latest Canary #73.0.3637.0 and issue is fixed. Now 'Speech' option is seen in context menu. Kindly review the attached screen-cast. Thank you!
,
Dec 11
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dd040bfffecff726afdbed6b27b7b228b0513b9 commit 1dd040bfffecff726afdbed6b27b7b228b0513b9 Author: Mathieu Perreault <mathp@chromium.org> Date: Tue Dec 11 15:59:14 2018 [Mac Context Menu] Add missing items to mac context menu (renderer) Due to bad refactoring in a previous change [1], some items like the Speech functionality was not being added properly. This is now fixed by allowing text_services_context_menu_.AppendToContextMenu(&menu_model_) to be called. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1045990/10/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm See Bug for repro steps. Bug: 904339 Change-Id: I1794cd24c4b9b7f68ef892aa851a01affbb5cbdb Reviewed-on: https://chromium-review.googlesource.com/c/1366865 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615117}(cherry picked from commit 911c660e261e874f0b98f46e3966ff86a93713b5) Reviewed-on: https://chromium-review.googlesource.com/c/1372229 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#254} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/1dd040bfffecff726afdbed6b27b7b228b0513b9/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm
,
Dec 13
Update : Retested above issue on Mac(10.13.1 , 10.13.6 , 10.14.2) OS using Beta #72.0.3626.17 and issue is fixed. Now 'Speech' option is seen in context menu. Kindly review the attached screen-cast. Thank you!
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1dd040bfffecff726afdbed6b27b7b228b0513b9 Commit: 1dd040bfffecff726afdbed6b27b7b228b0513b9 Author: mathp@chromium.org Commiter: mathp@chromium.org Date: 2018-12-11 15:59:14 +0000 UTC [Mac Context Menu] Add missing items to mac context menu (renderer) Due to bad refactoring in a previous change [1], some items like the Speech functionality was not being added properly. This is now fixed by allowing text_services_context_menu_.AppendToContextMenu(&menu_model_) to be called. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1045990/10/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm See Bug for repro steps. Bug: 904339 Change-Id: I1794cd24c4b9b7f68ef892aa851a01affbb5cbdb Reviewed-on: https://chromium-review.googlesource.com/c/1366865 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615117}(cherry picked from commit 911c660e261e874f0b98f46e3966ff86a93713b5) Reviewed-on: https://chromium-review.googlesource.com/c/1372229 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#254} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tkent@chromium.org
, Nov 12