Infobar bottom shadow isn't visible against dark pages
Reported by
shruti.j...@etouch.net,
Nov 12
|
||
Issue descriptionChrome Version: 72.0.3608.0 Revision 13a876533812d5e196bca2b1c60634dc14a79700-refs/branch-heads/3608@{#1}(64 bit) OS: Mac(10.13.1 , 10.13.6 , 10.14.1) Pre-condition:Login to gmail with valid credentials Test URL:https://chrome.google.com/webstore/detail/morpheon-dark/mafbdhjdkjnoafhfelkjpchpaepjknad?utm_source=chrome-ntp-icon Steps to reproduce: 1. Launch chrome and navigate to above URL and install theme. 2. Navigate to hangout.google.com and click on 'video call'. 3. Block 'Camera' and 'Microphone' permission ,click on security chip and change the permission to 'Ask Default'. 4. Observe the 'Reload' bar after changing the permissions. Actual Result : Unable to visually differentiate between 'Reload' bar and page's content in video-call window. Expected Result : 'Reload' bar should have some bottom line so that it can differentiate page and 'Reload' bar. This is a regression issue broken in M-70 and below is the bisect information: Good Build : 70.0.3503.0 (Revision : 578160) Bad Build : 70.0.3504.0 (Revision : 578510) You are probably looking for a change made after 578333 (known good), but no later than 578334 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/bcb7db78edc13f57577f0a9562c98918bdcc10ae..67d21d10815fe6d87d1785a65a50fbc386e6605b Suspecting: https://chromium.googlesource.com/chromium/src/+/67d21d10815fe6d87d1785a65a50fbc386e6605b @ellyjones:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly refer the attached screencast from drive link: https://drive.google.com/open?id=1XMnmumLtGWrXcqN4QniTiSeZRjtTTevo Note : 1.Pardon me if it is intended as visually differentiating between page and 'Reload' bar is difficult. 2.Issue is not seen on OS: Windows(7,8,8.1,10) and Linux(14.04 LTS) Thank You!
,
Dec 12
This isn't specifically related to Mac. Basically the issue is simply that infobars use a shadow to distinguish the bottom of the last infobar from the page, and that isn't visible when the page background is dark. In the default theme the infobar happens to be white, which provides its own separator, but if the infobar is dark (as in the custom theme here) then neither infobar body nor shadow is terribly visible. We could try to explicitly draw a divider above the shadow -- we already draw dividers between infobars where there are multiple ones. Or we could limit that to just "cases where the infobar is not light-background", or something. This is really a question for design. ->bettes@ for an opinion. |
||
►
Sign in to add a comment |
||
Comment 1 by ellyjo...@chromium.org
, Nov 12Owner: pkasting@chromium.org