Float-cast-overflow in blink::CSSColorInterpolationType::ResolveInterpolableColor |
|||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=4800260586864640 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Float-cast-overflow Crash Address: Crash State: blink::CSSColorInterpolationType::ResolveInterpolableColor blink::ShadowInterpolationFunctions::CreateShadowData blink::filter_interpolation_functions::CreateFilter Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:563900 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4800260586864640 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Nov 12
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/9831ecc703d4316100735d9ed9a86702d3a34652 (Disable non-composited animations via feature policy). If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
,
Nov 12
,
Nov 12
Xida, is this the same issue as 900493?
,
Nov 22
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57801af4c63aace5f0737260e92917a3394824a6 commit 57801af4c63aace5f0737260e92917a3394824a6 Author: Xida Chen <xidachen@chromium.org> Date: Tue Nov 27 17:25:05 2018 Fix float-cast overflow in css_color_interpolation_type.cc This is due to implicit cast from double to int, add static_cast would fix it. Bug: 904333 Change-Id: I91a5120e67cd5e2eab7d0ea373b826cc3cbff104 Reviewed-on: https://chromium-review.googlesource.com/c/1350331 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611161} [modify] https://crrev.com/57801af4c63aace5f0737260e92917a3394824a6/third_party/blink/renderer/core/animation/css_color_interpolation_type.cc
,
Nov 27
,
Dec 4
ClusterFuzz testcase 4800260586864640 is still reproducing on tip-of-tree build (trunk). Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.
,
Dec 4
re-open, this would likely be fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/1357209 But we need a layout test for this.
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4699975e31344eec45e253eb9ae95d76f475e86 commit d4699975e31344eec45e253eb9ae95d76f475e86 Author: Xida Chen <xidachen@chromium.org> Date: Wed Dec 05 04:21:03 2018 [Layout test] Add a test case for float-cast-overflow The ResolveInterpolableColor could cause a float-cast-overflow, which has been fixed in: https://chromium-review.googlesource.com/c/chromium/src/+/1357209 This CL adds a layout test to prevent future regression. Bug: 904333 Change-Id: Ib3021abc7dc37cdb618f730e77df3983a01cbd93 Reviewed-on: https://chromium-review.googlesource.com/c/1361589 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#613864} [modify] https://crrev.com/d4699975e31344eec45e253eb9ae95d76f475e86/third_party/blink/web_tests/animations/interpolation/filter-interpolation-002.html
,
Dec 5
,
Dec 5
ClusterFuzz has detected this issue as fixed in range 613589:613594. Detailed report: https://clusterfuzz.com/testcase?key=4800260586864640 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Float-cast-overflow Crash Address: Crash State: blink::CSSColorInterpolationType::ResolveInterpolableColor blink::ShadowInterpolationFunctions::CreateShadowData blink::filter_interpolation_functions::CreateFilter Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:563900 Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=613589:613594 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4800260586864640 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Dec 5
ClusterFuzz testcase 4800260586864640 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by ClusterFuzz
, Nov 12Labels: Test-Predator-Auto-Components