New issue
Advanced search Search tips

Issue 904333 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Float-cast-overflow in blink::CSSColorInterpolationType::ResolveInterpolableColor

Project Member Reported by ClusterFuzz, Nov 12

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4800260586864640

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::CSSColorInterpolationType::ResolveInterpolableColor
  blink::ShadowInterpolationFunctions::CreateShadowData
  blink::filter_interpolation_functions::CreateFilter
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:563900

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4800260586864640

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 12

Components: Blink>Animation
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 12

Labels: Test-Predator-Auto-Owner
Owner: iclell...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/9831ecc703d4316100735d9ed9a86702d3a34652 (Disable non-composited animations via feature policy).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Labels: Stability-Crash
Xida, is this the same issue as 900493?

Comment 5 Deleted

Cc: iclell...@chromium.org
Owner: xidac...@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57801af4c63aace5f0737260e92917a3394824a6

commit 57801af4c63aace5f0737260e92917a3394824a6
Author: Xida Chen <xidachen@chromium.org>
Date: Tue Nov 27 17:25:05 2018

Fix float-cast overflow in css_color_interpolation_type.cc

This is due to implicit cast from double to int, add static_cast would
fix it.

Bug:  904333 
Change-Id: I91a5120e67cd5e2eab7d0ea373b826cc3cbff104
Reviewed-on: https://chromium-review.googlesource.com/c/1350331
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611161}
[modify] https://crrev.com/57801af4c63aace5f0737260e92917a3394824a6/third_party/blink/renderer/core/animation/css_color_interpolation_type.cc

Status: Fixed (was: Assigned)
Project Member

Comment 9 by ClusterFuzz, Dec 4

Labels: Needs-Feedback
ClusterFuzz testcase 4800260586864640 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.
Status: Assigned (was: Fixed)
re-open, this would likely be fixed by:
https://chromium-review.googlesource.com/c/chromium/src/+/1357209

But we need a layout test for this.
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4699975e31344eec45e253eb9ae95d76f475e86

commit d4699975e31344eec45e253eb9ae95d76f475e86
Author: Xida Chen <xidachen@chromium.org>
Date: Wed Dec 05 04:21:03 2018

[Layout test] Add a test case for float-cast-overflow

The ResolveInterpolableColor could cause a float-cast-overflow, which
has been fixed in:
https://chromium-review.googlesource.com/c/chromium/src/+/1357209

This CL adds a layout test to prevent future regression.

Bug:  904333 
Change-Id: Ib3021abc7dc37cdb618f730e77df3983a01cbd93
Reviewed-on: https://chromium-review.googlesource.com/c/1361589
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613864}
[modify] https://crrev.com/d4699975e31344eec45e253eb9ae95d76f475e86/third_party/blink/web_tests/animations/interpolation/filter-interpolation-002.html

Status: Fixed (was: Assigned)
Project Member

Comment 13 by ClusterFuzz, Dec 5

ClusterFuzz has detected this issue as fixed in range 613589:613594.

Detailed report: https://clusterfuzz.com/testcase?key=4800260586864640

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::CSSColorInterpolationType::ResolveInterpolableColor
  blink::ShadowInterpolationFunctions::CreateShadowData
  blink::filter_interpolation_functions::CreateFilter
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:563900
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=613589:613594

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4800260586864640

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 14 by ClusterFuzz, Dec 5

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4800260586864640 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment