New issue
Advanced search Search tips

Issue 904318 link

Starred by 1 user
Status: Fixed
Owner:
harrisjay@chromium.org
Closed: Nov 14
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
k...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Separator line in omnibox disappear on tab switching.

Reported by db...@etouch.net, Nov 12 
Chrome Version: 72.0.3608.0 Revision 13a876533812d5e196bca2b1c60634dc14a79700-refs/branch-heads/3608@{#1}(32/64 bit)
OS: Windows(7,8,8.1,10), Linux(14.04 LTS).

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://version page and open NTP 
(2) Come back to chrome://version page and click on View site info icon and then swtich between tabs.
(3) Observe vertical separator line in omnibox.

Actual: Separator line in omnibox disappear on tab switching. 

Expected:  separator line in omnibox should not disappear on tab switching. 

This is a regression issue, broken in 'M72', will soon update the other info:

Good Build:72.0.3596.0(Revision: 603701)
Bad Build: 72.0.3597.0(Revision: 604471)
Actual_Video.mp4
972 KB View Download
Expected_video.mp4
520 KB View Download

Comment 1 by db...@etouch.net, Nov 12

Labels: hasbisect
Owner: harrisjay@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 603749(known good), but no later than 603754(first known bad).

CHANGE-LOG URL:
  
https://chromium.googlesource.com/chromium/src/+log/57cea39f336a9465aafdec373867b9c36de9394c..ff9f2eda72fbd648ad894028b22becfea3227fba

Suspecting: https://chromium.googlesource.com/chromium/src/+/96a0c5e6d815f70ef9c63b6b05131586e858d5b3

@harrisjay: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1) Providing suspect using chromium bisect script because unable to perform bisect using 'per-revision' script.
2) Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting following error:
   - Error message on Mac OS:[Errno 2] No such file or directory error message
   - Error message on Windows OS: RuntimeError: We don't have enough builds to bisect.
3) Issue is not seen on Mac(10.13.1,10.13.6,10.14.1)

Kindly refer the attached screen-cast.

Comment 2 by mpear...@chromium.org, Nov 12

Cc: k...@chromium.org
CC krb@, just for awareness

Comment 3 by harrisjay@chromium.org, Nov 12

Status: Started (was: Assigned)
Confirmed, looking into a fix.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e574e27caf09a7af60ffa25fd7af460ebc545736

commit e574e27caf09a7af60ffa25fd7af460ebc545736
Author: Jay Harris <harrisjay@chromium.org>
Date: Tue Nov 13 22:13:18 2018

Update separator opacity on visibility change

Bug:  904318 
Change-Id: I3c0367bc925a5f3b78f3a0457c25ef3b7c807b38
Reviewed-on: https://chromium-review.googlesource.com/c/1333007
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607765}
[modify] https://crrev.com/e574e27caf09a7af60ffa25fd7af460ebc545736/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc

Comment 6 by harrisjay@chromium.org, Nov 14

Status: Fixed (was: Started)

Comment 7 by db...@etouch.net, Nov 14

Labels: TE-Verified-M72 TE-Verified-72.0.3610.0
Update:

Rechecked the above issue on latest canary build #72.0.3610.0 using Windows(7,8,8.1,10), Linux(14.04 LTS) OS and it is fixed.

Kindly refer attached screen-cast.

Thank you.
Fix_Issue.mp4
855 KB View Download
►

Sign in to add a comment