Issue metadata
Sign in to add a comment
|
Android app icons are blurry in the shelf
Reported by
valha...@gmail.com,
Nov 12
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS aarch64 11021.56.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.76 Safari/537.36 Platform: 11021.56.0 (Official Build) stable-channel bob Steps to reproduce the problem: 1. Pin a few Android apps to the shelf (best if they have somewhat complex and small elements in the icon design); 2. Pin a few Chrome apps to the shelf; 3. Compare Android app icons to Chrome app icons. What is the expected behavior? Android app icons shouldn't look any different from Chrome app icons in the shelf. What went wrong? Android app icons look blurry, as if they were rasterized versions of the older style (smaller) shelf icons, upscaled to the new (larger) shelf. Did this work before? Yes 69.0.3497.95 Stable, and previous versions Chrome version: 70.0.3538.76 Channel: stable OS Version: 11021.56.0 Flash Version: 31.0.0.122 Understandably, this doesn't look like a big deal. But let's be fair, these things don't belong on the Stable channel, and the more UI bugs there are, the worse overall experience gets from an average user perspective.
,
Nov 19
+ kaznacheev and khmel since this is an ARC icon issue.
,
Nov 27
,
Nov 27
valhakun@gmail.com, can you provide more info? Specifically, if you look at Internal Display section in chrome://settings/display, what do you see under "Display Size"? What percentage is the slider at?
,
Nov 27
kaznacheev@chromium.org, scaling is 100% at native 1280×800 (10.1").
,
Nov 27
Found possibly related but separate Issue 908968
,
Dec 1
This is not in fact related to Issue 908968 . The root cause is that at certain resolutions shelf icons are upscaled from 48px icons instead of being downscaled from 96px, which is done on purpose at https://cs.chromium.org/chromium/src/ui/gfx/image/image_skia.cc?rcl=236d77339005bf81b2a33f13427cc58a903eedad&l=48. Changing the threshold from 0.2 to 0 fixes the problem.
,
Dec 4
Found some interesting symptoms. For bundled Play Store apps such as Play Music, there is very visible difference between the icon bundled with the OS image (sharp) and the one loaded from up-to-date apk (blurry). The difference is observable for 48px icon, but not for larger ones.
,
Dec 4
,
Dec 4
,
Dec 4
Frankly, I wouldn't mind having a smaller shelf, adjusted to 48px icons. Or an option to make it smaller on sub-12" low-res displays.
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0e8075ebb34a7197fdbdf93a7ae3c1a59b87fd8 commit f0e8075ebb34a7197fdbdf93a7ae3c1a59b87fd8 Author: khmel@chromium.org <khmel@chromium.org> Date: Thu Dec 06 02:50:08 2018 arc: Add ability to invalidate app icons. This is required when we changed icon processing on Android side and would like to apply these changes in case previous apps icons are already cached. TEST=In context of ag/5700881. Blurred icons turned to normal version. unit tests extended. BUG= 904278 Change-Id: I68c4ab8669eb46a56e34316fc154b7554c0ff7a2 Reviewed-on: https://chromium-review.googlesource.com/c/1362463 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#614246} [modify] https://crrev.com/f0e8075ebb34a7197fdbdf93a7ae3c1a59b87fd8/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/f0e8075ebb34a7197fdbdf93a7ae3c1a59b87fd8/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h [modify] https://crrev.com/f0e8075ebb34a7197fdbdf93a7ae3c1a59b87fd8/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
,
Dec 13
,
Dec 13
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98beb211bbd905656b8b1558023f43cca08a8ac4 commit 98beb211bbd905656b8b1558023f43cca08a8ac4 Author: khmel@chromium.org <khmel@chromium.org> Date: Fri Dec 14 17:25:22 2018 arc: Add ability to invalidate app icons. This is required when we changed icon processing on Android side and would like to apply these changes in case previous apps icons are already cached. TEST=In context of ag/5700881. Blurred icons turned to normal version. unit tests extended. BUG= 904278 Change-Id: I68c4ab8669eb46a56e34316fc154b7554c0ff7a2 Reviewed-on: https://chromium-review.googlesource.com/c/1362463 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614246}(cherry picked from commit f0e8075ebb34a7197fdbdf93a7ae3c1a59b87fd8) Reviewed-on: https://chromium-review.googlesource.com/c/1377374 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#361} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/98beb211bbd905656b8b1558023f43cca08a8ac4/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/98beb211bbd905656b8b1558023f43cca08a8ac4/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h [modify] https://crrev.com/98beb211bbd905656b8b1558023f43cca08a8ac4/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
,
Dec 14
Fixed in 72
,
Dec 19
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 98beb211bbd905656b8b1558023f43cca08a8ac4 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98beb211bbd905656b8b1558023f43cca08a8ac4 Commit: 98beb211bbd905656b8b1558023f43cca08a8ac4 Author: khmel@chromium.org Commiter: khmel@chromium.org Date: 2018-12-14 17:25:22 +0000 UTC arc: Add ability to invalidate app icons. This is required when we changed icon processing on Android side and would like to apply these changes in case previous apps icons are already cached. TEST=In context of ag/5700881. Blurred icons turned to normal version. unit tests extended. BUG= 904278 Change-Id: I68c4ab8669eb46a56e34316fc154b7554c0ff7a2 Reviewed-on: https://chromium-review.googlesource.com/c/1362463 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614246}(cherry picked from commit f0e8075ebb34a7197fdbdf93a7ae3c1a59b87fd8) Reviewed-on: https://chromium-review.googlesource.com/c/1377374 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#361} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by zalcorn@chromium.org
, Nov 16