New issue
Advanced search Search tips

Issue 904263 link

Starred by 1 user
Status: Fixed
Owner:
mstensho@chromium.org
Closed: Nov 12
Cc:
mstensho@chromium.org
robertma@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/css/css-multicol by import https://crrev.com/c/1331167

 
WPT import https://crrev.com/c/1331167 introduced new failures in external/wpt/css/css-multicol:

List of new failures:
virtual/layout_ng_experimental/external/wpt/css/css-multicol/multicol-margin-003.html [ Failure ]
external/wpt/css/css-multicol/multicol-margin-003.html [ Failure ]

This import contains upstream changes from a0610cf468e6208e74b2cfda77a565ab90fbd74e to fc1a5b73230225faf32bfb85f3928ce154211b0a:
Remove ES6 object matching shorthand notation from WebDriver tests (#14015): https://github.com/web-platform-tests/wpt/commit/fc1a5b73230225faf32bfb85f3928ce154211b0a
Update to new ServiceWorker spec link: https://github.com/web-platform-tests/wpt/commit/926d722bfc83f3135aab36fddc977de82ed7e63e
Make images without alt generate a replaced box regardless of src.: https://github.com/web-platform-tests/wpt/commit/abc39b85889509a3d101fd70f930e6f2f2776a4e
Part 2 - Do not carry block-end margin out of ColumnSetFrame.: https://github.com/web-platform-tests/wpt/commit/f631930744c301d07f344b9eb41774af8173e802 [affecting this directory]

Comment 1 by mstensho@chromium.org, Nov 12

Owner: mstensho@chromium.org
Status: Assigned (was: Untriaged)
The test leaves orphans / widows at their initial value (2), but the test assumes that we may freely break wherever we want, so engines that support them (like Blink) will fail the test.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0c7c0027d22fd6efad1cd55cbaa24cc144e4b6f

commit f0c7c0027d22fd6efad1cd55cbaa24cc144e4b6f
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Mon Nov 12 13:34:44 2018

Set orphans and widows to 1 in new multicol test.

The test left orphans / widows at their initial value (2), but did
assume that we could freely break wherever we wanted. Blink honors
orphans and widows requirements inside multicol containers, so set
them to 1, to get the behavior that the test expects.

Bug:  904263 
Change-Id: Ia138da5c65b1c5da450441f38e033320bc983a94
Reviewed-on: https://chromium-review.googlesource.com/c/1331389
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607211}
[modify] https://crrev.com/f0c7c0027d22fd6efad1cd55cbaa24cc144e4b6f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/f0c7c0027d22fd6efad1cd55cbaa24cc144e4b6f/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-margin-003.html

Comment 3 by mstensho@chromium.org, Nov 12

Status: Fixed (was: Assigned)
►

Sign in to add a comment