New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 904231 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Tooltips appear for shelf icons after pointer is moved away

Project Member Reported by derat@chromium.org, Nov 11

Issue description

Google Chrome	70.0.3538.76 (Official Build) (64-bit)
Revision	22757df8a5ddfacf2eaf57b85f4ea54c14b8f87a-refs/branch-heads/3538@{#1031}
Platform	11021.56.0 (Official Build) stable-channel eve

1. Move the pointer over an icon in the shelf.
2. Before a tooltip is displayed, move the pointer out of the shelf (e.g. over a browser window or the desktop).

A second or two later, the tooltip for the icon in step 1 appears. I'm guessing there's a timer that's not getting stopped on leave/exit.

This is also mentioned in the Reddit thread at https://www.reddit.com/r/chromeos/comments/9vqvvw/stable_version_70_impressions_bugs_and_glitches/e9er2u9/ .
 
Labels: -M-70 M-72
Targeting M-72. 
Manu, I can take this one if you aren't free :D
Status: Started (was: Assigned)
FYI fix in progress at CL 1341648
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfd5ef53d800ee0abc0a417bf847f0a627ddc6f7

commit dfd5ef53d800ee0abc0a417bf847f0a627ddc6f7
Author: Manu Cornet <manucornet@chromium.org>
Date: Mon Nov 19 23:25:04 2018

CrOS shelf: stop tooltip timer when the mouse is elsewhere

Bug:  904231 
Change-Id: I0eeb3131339da7d9c3cbeb308e7df50acd85220d
Reviewed-on: https://chromium-review.googlesource.com/c/1341648
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609501}
[modify] https://crrev.com/dfd5ef53d800ee0abc0a417bf847f0a627ddc6f7/ash/shelf/shelf_tooltip_manager.cc

Status: Fixed (was: Started)
Cc: geohsu@chromium.org jennschen@chromium.org kbleicher@chromium.org
Labels: Merge-Request-70 Merge-Request-71
This is a trivial fix for an annoying regression that affects all users essentially all the time; please merge it.

Geo, are there any more M70 releases planned?
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 20

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Request-70 -Merge-Review-71 Merge-Rejected-70 Merge-Approved-71
No more planned M70 releases. M71 Stable is coming up soon.

Approved for ChromeOS M71.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 26

Cc: geo...@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: ReleaseBlock-Stable
Labels: -M-72 M-71
Please merge the fix to M71.
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 29

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad7d44ddc5645743bc56479919acf6d9a76e6cd5

commit ad7d44ddc5645743bc56479919acf6d9a76e6cd5
Author: Manu Cornet <manucornet@chromium.org>
Date: Thu Nov 29 22:48:52 2018

CrOS shelf: stop tooltip timer when the mouse is elsewhere

Bug:  904231 
Change-Id: I0eeb3131339da7d9c3cbeb308e7df50acd85220d
Reviewed-on: https://chromium-review.googlesource.com/c/1341648
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#609501}(cherry picked from commit dfd5ef53d800ee0abc0a417bf847f0a627ddc6f7)
Reviewed-on: https://chromium-review.googlesource.com/c/1356011
Cr-Commit-Position: refs/branch-heads/3578@{#854}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/ad7d44ddc5645743bc56479919acf6d9a76e6cd5/ash/shelf/shelf_tooltip_manager.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/ad7d44ddc5645743bc56479919acf6d9a76e6cd5

Commit: ad7d44ddc5645743bc56479919acf6d9a76e6cd5
Author: manucornet@chromium.org
Commiter: newcomer@chromium.org
Date: 2018-11-29 22:48:52 +0000 UTC

CrOS shelf: stop tooltip timer when the mouse is elsewhere

Bug:  904231 
Change-Id: I0eeb3131339da7d9c3cbeb308e7df50acd85220d
Reviewed-on: https://chromium-review.googlesource.com/c/1341648
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#609501}(cherry picked from commit dfd5ef53d800ee0abc0a417bf847f0a627ddc6f7)
Reviewed-on: https://chromium-review.googlesource.com/c/1356011
Cr-Commit-Position: refs/branch-heads/3578@{#854}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Cc: manucornet@chromium.org
 Issue 887195  has been merged into this issue.

Sign in to add a comment