Overview -> homecher transition with netflix playing janks, also netflix keeps playing in the background |
||||||||||
Issue descriptionChrome Version: 71.0.3578.39 What steps will reproduce the problem? (1) Open a few apps, netflix being one of them. (2) Play netflix (produces audio). (3) Go to overview mode. (4) go to homecher What is the expected result? Homecher shows. What happens instead? The netflix window plays the "minimze animation" from its current position in overview. This animation appears over the homecher. Then netflix continues to play in the background even though it should not.
,
Dec 3
Bulk moving <p-1's to the next milestone because we branched to M-73.
,
Dec 3
(didn't mean to grab these P-1's)
,
Dec 12
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4bf3776cac752df8bb8ccf832b45611088456b9 commit f4bf3776cac752df8bb8ccf832b45611088456b9 Author: Sammie Quon <sammiequon@google.com> Date: Thu Dec 13 20:19:12 2018 overview: Hide windows before minimizing. It seems for arc apps this is needed, otherwise the minimize animation will still play. Its also what HomeLauncherGestureHandler does. Test: manual Bug: 904134 Change-Id: Idaed19ed11fe9b15ed2d9aa1e461017503bd6149 Reviewed-on: https://chromium-review.googlesource.com/c/1376711 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#616416} [modify] https://crrev.com/f4bf3776cac752df8bb8ccf832b45611088456b9/ash/wm/overview/window_selector_controller.cc
,
Dec 13
I couldn't repro the app still playing music, but the patch in c#5 will fix the weird minimizing animation. Feel free to reopen a new bug if audio bug resurfaces.
,
Dec 14
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22be926fdf7e41dd1dc933b4fa651fa6eac6fc1b commit 22be926fdf7e41dd1dc933b4fa651fa6eac6fc1b Author: Sammie Quon <sammiequon@google.com> Date: Fri Dec 14 16:59:13 2018 [merge to 72] overview: Hide windows before minimizing. It seems for arc apps this is needed, otherwise the minimize animation will still play. Its also what HomeLauncherGestureHandler does. TBR=sammiequon@google.com (cherry picked from commit f4bf3776cac752df8bb8ccf832b45611088456b9) Test: manual Bug: 904134 Change-Id: Idaed19ed11fe9b15ed2d9aa1e461017503bd6149 Reviewed-on: https://chromium-review.googlesource.com/c/1376711 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616416} Reviewed-on: https://chromium-review.googlesource.com/c/1378099 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#360} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/22be926fdf7e41dd1dc933b4fa651fa6eac6fc1b/ash/wm/overview/window_selector_controller.cc
,
Dec 14
,
Dec 19
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 22be926fdf7e41dd1dc933b4fa651fa6eac6fc1b was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22be926fdf7e41dd1dc933b4fa651fa6eac6fc1b Commit: 22be926fdf7e41dd1dc933b4fa651fa6eac6fc1b Author: sammiequon@google.com Commiter: sammiequon@chromium.org Date: 2018-12-14 16:59:13 +0000 UTC [merge to 72] overview: Hide windows before minimizing. It seems for arc apps this is needed, otherwise the minimize animation will still play. Its also what HomeLauncherGestureHandler does. TBR=sammiequon@google.com (cherry picked from commit f4bf3776cac752df8bb8ccf832b45611088456b9) Test: manual Bug: 904134 Change-Id: Idaed19ed11fe9b15ed2d9aa1e461017503bd6149 Reviewed-on: https://chromium-review.googlesource.com/c/1376711 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616416} Reviewed-on: https://chromium-review.googlesource.com/c/1378099 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#360} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by newcomer@chromium.org
, Nov 14Owner: sammiequon@chromium.org