New issue
Advanced search Search tips

Issue 904119 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

platform.Memd failure on veyron_rialto-release

Project Member Reported by derat@chromium.org, Nov 10

Issue description

https://stainless.corp.google.com/browse/chromeos-autotest-results/256371738-chromeos-test/

2018/11/09 07:27:15 Started test platform.Memd
2018/11/09 07:27:15 [07:27:15.326] External command failed: exit status 1
2018/11/09 07:27:15 [07:27:15.327] Command: initctl status memd
2018/11/09 07:27:15 [07:27:15.327] Uncaptured output:
initctl: Unknown job: memd
2018/11/09 07:27:15 [07:27:15.327] Error at memd.go:130: Could not get memd job status: exit status 1
2018/11/09 07:27:15 [07:27:15.327] Stack trace:
Could not get memd job status
	at chromiumos/tast/local/bundles/cros/platform.Memd (memd.go:130)
	at chromiumos/tast/testing.(*Test).Run.func4 (test.go:189)
	at chromiumos/tast/testing.runStages.func1.1 (stage.go:39)
	at chromiumos/tast/testing.runAndRecover.func1 (stage.go:69)
	at runtime.goexit (asm_arm.s:1015)
exit status 1
2018/11/09 07:27:15 Completed test platform.Memd in 92ms with 1 error(s)

This was veyron_rialto-release. If memd is disabled on veyron_rialto, please add an "memd" software feature and make the test depend on it so that it'll be skipped there. See http://go/tast-deps (and previous changes to the files that it mentions) for details about how to do this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0919fc073ce3b5624dd047408c812b4cd6a7b0da

commit 0919fc073ce3b5624dd047408c812b4cd6a7b0da
Author: Luigi Semenzato <semenzato@chromium.org>
Date: Thu Nov 15 10:18:26 2018

tast-use-flags: add "memd" use flag

We need this to be able to turn off memd tast-testing
on systems that don't run memd.

BUG= chromium:904119 
TEST=none

Change-Id: I39cc8a1469813a28c63f989adb512e0009d8e09f
Reviewed-on: https://chromium-review.googlesource.com/1335680
Commit-Ready: Luigi Semenzato <semenzato@chromium.org>
Tested-by: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[rename] https://crrev.com/0919fc073ce3b5624dd047408c812b4cd6a7b0da/chromeos-base/tast-use-flags/tast-use-flags-0.0.1-r12.ebuild
[modify] https://crrev.com/0919fc073ce3b5624dd047408c812b4cd6a7b0da/chromeos-base/tast-use-flags/tast-use-flags-0.0.1.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/1db30919f3dd163bf21376b6f855386965f3e438

commit 1db30919f3dd163bf21376b6f855386965f3e438
Author: Luigi Semenzato <semenzato@chromium.org>
Date: Fri Nov 16 02:49:24 2018

tast-tests: platform/memd.go: restrict to devices with memd

The memd memory daemon does not run on all systems (depending
on the "memd" USE flag, which is ON by default).
This test must only run on devices where memd runs.

CQ-DEPEND=CL:1335895
BUG= chromium:904119 
TEST=none

Change-Id: I4a26f6a228321a4b3c41d1d42aec3ed9843b8485
Reviewed-on: https://chromium-review.googlesource.com/1335840
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>

[modify] https://crrev.com/1db30919f3dd163bf21376b6f855386965f3e438/src/chromiumos/tast/local/bundles/cros/platform/memd.go

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/edde0719356d39fd1c1b8ee65dce62931b466b80

commit edde0719356d39fd1c1b8ee65dce62931b466b80
Author: Luigi Semenzato <semenzato@chromium.org>
Date: Fri Nov 16 02:49:24 2018

tast: add memd dependency

Only platforms with USE=memd (which is included by default)
run memd.  This CL is a requisite for turning off the Memd
tast test on platforms that do not run memd.

CQ-DEPEND=CL:1335680
BUG= chromium:904119 
TEST=none

Change-Id: Ic16c3241b517be21ee1945c164f4f26444b4f34d
Reviewed-on: https://chromium-review.googlesource.com/1335895
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/edde0719356d39fd1c1b8ee65dce62931b466b80/src/chromiumos/cmd/local_test_runner/main.go
[modify] https://crrev.com/edde0719356d39fd1c1b8ee65dce62931b466b80/docs/test_dependencies.md

Status: Fixed (was: Assigned)
This should fix the problem.

Sign in to add a comment