New issue
Advanced search Search tips

Issue 904101 link

Starred by 1 user
Status: Fixed
Owner:
justincohen@chromium.org
Closed: Nov 14
Cc:
rohitrao@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: ----



Sign in to add a comment

Build errors when building Chromium for iOS on case-sensitive filesystem

Reported by noto...@gmail.com, Nov 10 
It's impossible to build Chromium for iOS on case-sensitive fs. Some of the imports have wrong case, for example UIKIt.h instead of UIKit.h and Webkit.h instead of WebKit.h. Patch is attached.
case_sensitive_fs_build_fix.patch
5.7 KB Download

Comment 1 by justincohen@chromium.org, Nov 14

Owner: justincohen@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/342db1c1553107c6ea92671bb62d3c6699014cdd

commit 342db1c1553107c6ea92671bb62d3c6699014cdd
Author: Justin Cohen <justincohen@google.com>
Date: Wed Nov 14 20:22:37 2018

[ios] Fix case on UIKit and WebKit includes.

Corrected cases found with:
   git grep -h "#import <.*>" ios | sort | uniq

Bug:  904101 
Change-Id: I17903375ef18d77bfd6f76052d6ea483a933ce56
Reviewed-on: https://chromium-review.googlesource.com/c/1335876
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608102}
[modify] https://crrev.com/342db1c1553107c6ea92671bb62d3c6699014cdd/ios/chrome/browser/ui/content_suggestions/content_suggestions_metrics_recording.h
[modify] https://crrev.com/342db1c1553107c6ea92671bb62d3c6699014cdd/ios/chrome/browser/ui/print/print_controller.mm
[modify] https://crrev.com/342db1c1553107c6ea92671bb62d3c6699014cdd/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_delegate.h
[modify] https://crrev.com/342db1c1553107c6ea92671bb62d3c6699014cdd/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_views.h
[modify] https://crrev.com/342db1c1553107c6ea92671bb62d3c6699014cdd/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_views_utils.h
[modify] https://crrev.com/342db1c1553107c6ea92671bb62d3c6699014cdd/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_input_assistant_items.h
[modify] https://crrev.com/342db1c1553107c6ea92671bb62d3c6699014cdd/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_keyboard_accessory_view.h
[modify] https://crrev.com/342db1c1553107c6ea92671bb62d3c6699014cdd/ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_ui_bar_button_item.h
[modify] https://crrev.com/342db1c1553107c6ea92671bb62d3c6699014cdd/ios/web/net/cookies/wk_http_system_cookie_store.h
[modify] https://crrev.com/342db1c1553107c6ea92671bb62d3c6699014cdd/ios/web/net/cookies/wk_http_system_cookie_store_unittest.mm

Comment 3 by justincohen@chromium.org, Nov 14

Cc: rohitrao@chromium.org
Components: UI>Browser
Status: Fixed (was: Assigned)
►

Sign in to add a comment