New issue
Advanced search Search tips

Issue 904037 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference WRITE in blink::StyleEngine::ResetAuthorStyle

Project Member Reported by ClusterFuzz, Nov 10

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6248575903989760

Fuzzer: lcamtuf_cross_fuzz
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Null-dereference WRITE
Crash Address: 0x0000000000b9
Crash State:
  blink::StyleEngine::ResetAuthorStyle
  blink::ShadowRoot::RemovedFrom
  blink::ContainerNode::NotifyNodeRemoved
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=606667:606674

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6248575903989760

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 10

Components: Blink>CSS Blink>DOM
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 10

Labels: Test-Predator-Auto-Owner
Owner: dtapu...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/c1727d16d1f96c5828d71d7d0c897d2bff6779c6 (Retire  CSSOMSmoothScroll flag).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: futhark@chromium.org
dtapuska@, have you looked at this one? It doesn't sound to me that your change is a likely culprit.
Owner: ----
Status: Untriaged (was: Assigned)
Moving to untriaged. I agree I don't think it would be related to my CL.
Cc: -futhark@chromium.org
Owner: futhark@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96846c0c8c82d4a6fd44dc9833add5fdbd980667

commit 96846c0c8c82d4a6fd44dc9833add5fdbd980667
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon Dec 03 18:06:46 2018

Null check for CSSGlobalRuleSet.

Presumably fixes UBSAN crasher. Seemingly so running locally with fuzzer
test case.

Bug:  904037 
Change-Id: Ie5804e28835528e65caadbf43308260b961a92b7
Reviewed-on: https://chromium-review.googlesource.com/c/1358446
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613155}
[modify] https://crrev.com/96846c0c8c82d4a6fd44dc9833add5fdbd980667/third_party/blink/renderer/core/css/style_engine.cc

Status: Fixed (was: Started)
Project Member

Comment 9 by ClusterFuzz, Dec 4

ClusterFuzz has detected this issue as fixed in range 613154:613159.

Detailed report: https://clusterfuzz.com/testcase?key=6248575903989760

Fuzzer: lcamtuf_cross_fuzz
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Null-dereference WRITE
Crash Address: 0x0000000000b9
Crash State:
  blink::StyleEngine::ResetAuthorStyle
  blink::ShadowRoot::RemovedFrom
  blink::ContainerNode::NotifyNodeRemoved
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=606667:606674
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=613154:613159

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6248575903989760

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Dec 4

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6248575903989760 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment