New issue
Advanced search Search tips

Issue 904009 link

Starred by 1 user
Status: Fixed
Owner:
dougarnett@chromium.org
Closed: Nov 29
Cc:
robertogden@chromium.org
ryansturm@chromium.org
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Add UMA for overall Previews metrics

Project Member Reported by sophiechang@chromium.org, Nov 9 
Things that would be helpful to have more generally for Previews:

Previews.EligibilityReason
- Allows for tracking whether we are serving more and more previews 
Previews.OptOuts
- Allows for tracking the improvement of the fidelity of previews.
Previews.PageEndReason
- Allows for tracking general reloads (reasoning pretty much same as above)

Comment 1 by robertogden@chromium.org, Nov 9

Cc: -robertogden@chromium.org
Labels: M-72
Owner: robertogden@chromium.org
Status: Assigned (was: Untriaged)
To clarify, these should basically be copies of the existing histograms with these names, but without the preview type suffix.

Comment 2 by sophiechang@chromium.org, Nov 10 

Yup! I think Tarun is already working on the opt-out one but the other ones are still up for grabs I think...

Comment 3 by robertogden@chromium.org, Nov 10

Cc: -tbansal@chromium.org robertogden@chromium.org
Owner: tbansal@chromium.org
Tarun, I'll let you do all three then since it sounds like a single CL

Comment 4 by tbansal@chromium.org, Nov 27

Owner: ryansturm@chromium.org
Ryan: Can I ask you to take this on? Thanks.

Comment 5 by sophiechang@chromium.org, Nov 28

Cc: dougarnett@chromium.org
I think Doug might be doing this but will have him confirm.

Comment 6 by dougarnett@chromium.org, Nov 28

Cc: -dougarnett@chromium.org ryansturm@chromium.org
Owner: dougarnett@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53634656825d5c65abc68f4a1e4ffa3fb885f5f2

commit 53634656825d5c65abc68f4a1e4ffa3fb885f5f2
Author: Doug Arnett <dougarnett@chromium.org>
Date: Thu Nov 29 16:29:07 2018

[Previews] Records overall counts for 3 Previews histograms

Records preview-type-agnostic counts for: Previews.OptOut.UserOptedOut,
Previews.PageEndReason, and Previews.EligibilityReason

Bug:  904009 
Change-Id: I13506b3b002a83a78d38a79006a02afa13a1c29f
Reviewed-on: https://chromium-review.googlesource.com/c/1354564
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612226}
[modify] https://crrev.com/53634656825d5c65abc68f4a1e4ffa3fb885f5f2/chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc
[modify] https://crrev.com/53634656825d5c65abc68f4a1e4ffa3fb885f5f2/chrome/browser/page_load_metrics/observers/previews_ukm_observer_unittest.cc
[modify] https://crrev.com/53634656825d5c65abc68f4a1e4ffa3fb885f5f2/components/previews/content/previews_decider_impl.cc
[modify] https://crrev.com/53634656825d5c65abc68f4a1e4ffa3fb885f5f2/components/previews/content/previews_decider_impl_unittest.cc
[modify] https://crrev.com/53634656825d5c65abc68f4a1e4ffa3fb885f5f2/components/previews/core/previews_black_list.cc
[modify] https://crrev.com/53634656825d5c65abc68f4a1e4ffa3fb885f5f2/components/previews/core/previews_black_list_unittest.cc

Comment 8 by dougarnett@chromium.org, Nov 29

Status: Fixed (was: Assigned)
Landed prior to M-72 branch
►

Sign in to add a comment